Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.h

Issue 22694006: Infobar system refactor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/infobar_android.h
===================================================================
--- chrome/browser/ui/android/infobars/infobar_android.h (revision 226624)
+++ chrome/browser/ui/android/infobars/infobar_android.h (working copy)
@@ -31,7 +31,7 @@
ACTION_TRANSLATE_SHOW_ORIGINAL = 4,
};
- InfoBarAndroid(InfoBarService* owner, InfoBarDelegate* delegate);
+ explicit InfoBarAndroid(scoped_ptr<InfoBarDelegate> delegate);
virtual ~InfoBarAndroid();
// InfoBar:
@@ -51,6 +51,7 @@
jstring action_value);
void OnCloseButtonClicked(JNIEnv* env, jobject obj);
+ // TODO(pkasting): Who calls this and why? Seems like it should go away
void OnInfoBarClosed(JNIEnv* env, jobject obj);
void CloseJavaInfoBar();
@@ -71,8 +72,6 @@
void CloseInfoBar();
private:
- // The InfoBar's delegate.
- InfoBarDelegate* delegate_;
base::android::ScopedJavaGlobalRef<jobject> java_info_bar_;
DISALLOW_COPY_AND_ASSIGN(InfoBarAndroid);

Powered by Google App Engine
This is Rietveld 408576698