Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: chrome/browser/media/midi_permission_infobar_delegate.cc

Issue 22694006: Infobar system refactor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/midi_permission_infobar_delegate.cc
===================================================================
--- chrome/browser/media/midi_permission_infobar_delegate.cc (revision 226624)
+++ chrome/browser/media/midi_permission_infobar_delegate.cc (working copy)
@@ -6,6 +6,7 @@
#include "chrome/browser/content_settings/permission_queue_controller.h"
#include "chrome/browser/content_settings/permission_request_id.h"
+#include "chrome/browser/infobars/infobar.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
@@ -17,36 +18,38 @@
#include "ui/base/l10n/l10n_util.h"
// static
-InfoBarDelegate* MIDIPermissionInfoBarDelegate::Create(
+InfoBar* MIDIPermissionInfoBarDelegate::Create(
InfoBarService* infobar_service,
PermissionQueueController* controller,
const PermissionRequestID& id,
const GURL& requesting_frame,
const std::string& display_languages) {
- return infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
- new MIDIPermissionInfoBarDelegate(infobar_service,
- controller,
- id,
- requesting_frame,
- display_languages)));
+ const content::NavigationEntry* committed_entry =
+ infobar_service->web_contents()->GetController().GetLastCommittedEntry();
+ return infobar_service->AddInfoBar(ConfirmInfoBarDelegate::CreateInfoBar(
+ scoped_ptr<ConfirmInfoBarDelegate>(new MIDIPermissionInfoBarDelegate(
+ controller, id, requesting_frame,
+ committed_entry ? committed_entry->GetUniqueID() : 0,
+ display_languages))));
}
MIDIPermissionInfoBarDelegate::MIDIPermissionInfoBarDelegate(
- InfoBarService* infobar_service,
PermissionQueueController* controller,
const PermissionRequestID& id,
const GURL& requesting_frame,
+ int contents_unique_id,
const std::string& display_languages)
- : ConfirmInfoBarDelegate(infobar_service),
+ : ConfirmInfoBarDelegate(),
controller_(controller),
id_(id),
requesting_frame_(requesting_frame),
+ contents_unique_id_(contents_unique_id),
display_languages_(display_languages) {
- const content::NavigationEntry* committed_entry = infobar_service->
- web_contents()->GetController().GetLastCommittedEntry();
- contents_unique_id_ = committed_entry ? committed_entry->GetUniqueID() : 0;
}
+MIDIPermissionInfoBarDelegate::~MIDIPermissionInfoBarDelegate() {
+}
+
void MIDIPermissionInfoBarDelegate::InfoBarDismissed() {
SetPermission(false, false);
}
@@ -94,8 +97,6 @@
void MIDIPermissionInfoBarDelegate::SetPermission(bool update_content_setting,
bool allowed) {
- controller_->OnPermissionSet(id_, requesting_frame_,
- web_contents()->GetURL(),
+ controller_->OnPermissionSet(id_, requesting_frame_, web_contents()->GetURL(),
update_content_setting, allowed);
}
-

Powered by Google App Engine
This is Rietveld 408576698