Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6774)

Unified Diff: chrome/browser/plugins/plugin_infobar_delegates.h

Issue 22694006: Infobar system refactor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_infobar_delegates.h
===================================================================
--- chrome/browser/plugins/plugin_infobar_delegates.h (revision 238220)
+++ chrome/browser/plugins/plugin_infobar_delegates.h (working copy)
@@ -24,8 +24,7 @@
// Base class for blocked plug-in infobars.
class PluginInfoBarDelegate : public ConfirmInfoBarDelegate {
protected:
- PluginInfoBarDelegate(InfoBarService* infobar_service,
- const std::string& identifier);
+ explicit PluginInfoBarDelegate(const std::string& identifier);
virtual ~PluginInfoBarDelegate();
// ConfirmInfoBarDelegate:
@@ -48,7 +47,7 @@
// Infobar that's shown when a plug-in requires user authorization to run.
class UnauthorizedPluginInfoBarDelegate : public PluginInfoBarDelegate {
public:
- // Creates an unauthorized plugin infobar delegate and adds it to
+ // Creates an unauthorized plugin infobar and delegate and adds the infobar to
// |infobar_service|.
static void Create(InfoBarService* infobar_service,
HostContentSettingsMap* content_settings,
@@ -56,8 +55,7 @@
const std::string& identifier);
private:
- UnauthorizedPluginInfoBarDelegate(InfoBarService* infobar_service,
- HostContentSettingsMap* content_settings,
+ UnauthorizedPluginInfoBarDelegate(HostContentSettingsMap* content_settings,
const string16& name,
const std::string& identifier);
virtual ~UnauthorizedPluginInfoBarDelegate();
@@ -82,7 +80,7 @@
class OutdatedPluginInfoBarDelegate : public PluginInfoBarDelegate,
public WeakPluginInstallerObserver {
public:
- // Creates an outdated plugin infobar delegate and adds it to
+ // Creates an outdated plugin infobar and delegate and adds the infobar to
// |infobar_service|.
static void Create(InfoBarService* infobar_service,
PluginInstaller* installer,
@@ -89,8 +87,7 @@
scoped_ptr<PluginMetadata> metadata);
private:
- OutdatedPluginInfoBarDelegate(InfoBarService* infobar_service,
- PluginInstaller* installer,
+ OutdatedPluginInfoBarDelegate(PluginInstaller* installer,
scoped_ptr<PluginMetadata> metadata,
const string16& message);
virtual ~OutdatedPluginInfoBarDelegate();
@@ -142,7 +139,7 @@
// Replaces |infobar|, which must currently be owned, with an infobar asking
// the user to install or update a particular plugin.
- static void Replace(InfoBarDelegate* infobar,
+ static void Replace(InfoBar* infobar,
PluginInstaller* installer,
scoped_ptr<PluginMetadata> plugin_metadata,
bool new_install,
@@ -149,9 +146,8 @@
const string16& message);
private:
- PluginInstallerInfoBarDelegate(InfoBarService* infobar_service,
- PluginInstaller* installer,
- scoped_ptr<PluginMetadata> plugin_metadata,
+ PluginInstallerInfoBarDelegate(PluginInstaller* installer,
+ scoped_ptr<PluginMetadata> metadata,
const InstallCallback& callback,
bool new_install,
const string16& message);
@@ -210,9 +206,7 @@
const string16& name);
private:
- PluginMetroModeInfoBarDelegate(InfoBarService* infobar_service,
- Mode mode,
- const string16& name);
+ PluginMetroModeInfoBarDelegate(Mode mode, const string16& name);
virtual ~PluginMetroModeInfoBarDelegate();
// ConfirmInfoBarDelegate:
« no previous file with comments | « chrome/browser/pepper_broker_infobar_delegate.cc ('k') | chrome/browser/plugins/plugin_infobar_delegates.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698