Infobar system refactor.

chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/infobars/extension_infobar_controller.h"
 
 #include <cmath>
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_infobar_delegate.h"
@@ skipping 33 matching lines @@
 - (CGFloat)clampedExtensionViewHeight;
 // Adjusts the width of the extension's hosted view to match the window's width
 // and sets the proper height for it as well.
 - (void)adjustExtensionViewSize;
 // Sets the image to be used in the button on the left side of the infobar.
 - (void)setButtonImage:(NSImage*)image;
 @end
 
 // A helper class to bridge the asynchronous Skia bitmap loading mechanism to
 // the extension's button.
-class InfobarBridge : public ExtensionInfoBarDelegate::DelegateObserver {
+class InfobarBridge {
  public:
   explicit InfobarBridge(ExtensionInfoBarController* owner)
       : owner_(owner),
         delegate_([owner delegate]->AsExtensionInfoBarDelegate()),
         weak_ptr_factory_(this) {
-    delegate_->set_observer(this);
     LoadIcon();
   }
 
-  virtual ~InfobarBridge() {
-    if (delegate_)
-      delegate_->set_observer(NULL);
-  }
-
   // Load the Extension's icon image.
   void LoadIcon() {
     const extensions::Extension* extension = delegate_->extension_host()->
         extension();
     extensions::ExtensionResource icon_resource =
         extensions::IconsInfo::GetIconResource(
             extension,
             extension_misc::EXTENSION_ICON_BITTY,
             ExtensionIconSet::MATCH_EXACTLY);
     extensions::ImageLoader* loader =
@@ skipping 32 matching lines @@
                          0, 0, icon->width(), icon->height(),
                          0, 0, image_size, image_size,
                          false);
     canvas->DrawImageInt(*drop_image,
                          image_size + kDropArrowLeftMarginPx,
                          image_size / 2);
     [owner_ setButtonImage:gfx::SkBitmapToNSImage(
         canvas->ExtractImageRep().sk_bitmap())];
   }
 
-  // Overridden from ExtensionInfoBarDelegate::DelegateObserver:
-  virtual void OnDelegateDeleted() OVERRIDE {
-    delegate_ = NULL;
-  }
-
  private:
   // Weak. Owns us.
   ExtensionInfoBarController* owner_;
 
   // Weak.
   ExtensionInfoBarDelegate* delegate_;
 
   base::WeakPtrFactory<InfobarBridge> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InfobarBridge);
 };
 
 
 @implementation ExtensionInfoBarController
 
-- (id)initWithInfoBar:(InfoBarCocoa*)infobar
-               window:(NSWindow*)window {
+- (id)initWithInfoBar:(InfoBarCocoa*)infobar {
   if ((self = [super initWithInfoBar:infobar])) {
-    window_ = window;
     dropdownButton_.reset([[MenuButton alloc] init]);
     [dropdownButton_ setOpenMenuOnClick:YES];
 
-    extensions::ExtensionHost* extensionHost =
-        [self delegate]->AsExtensionInfoBarDelegate()->extension_host();
-    Browser* browser = chrome::FindBrowserWithWebContents(
-        [self infobar]->OwnerCocoa()->web_contents());
-    contextMenuController_.reset([[ExtensionActionContextMenuController alloc]
-        initWithExtension:extensionHost->extension()
-                  browser:browser
-          extensionAction:NULL]);
-
     base::scoped_nsobject<NSMenu> contextMenu(
         [[NSMenu alloc] initWithTitle:@""]);
     [contextMenu setDelegate:self];
     // See menu_button.h for documentation on why this is needed.
     [contextMenu addItemWithTitle:@"" action:NULL keyEquivalent:@""];
     [dropdownButton_ setAttachedMenu:contextMenu];
 
     bridge_.reset(new InfobarBridge(self));
   }
   return self;
@@ skipping 49 matching lines @@
   // the parent infobar view matches the height of the extension's native view.
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(extensionViewFrameChanged)
              name:NSViewFrameDidChangeNotification
            object:extensionView_];
 
   [[NSNotificationCenter defaultCenter]
       addObserver:self
          selector:@selector(adjustExtensionViewSize)
-             name:NSWindowDidResizeNotification
-           object:window_];
+             name:NSViewFrameDidChangeNotification
+           object:[self view]];
 }
 
 - (void)infobarWillClose {
   [self disablePopUpMenu:[dropdownButton_ menu]];
   [super infobarWillClose];
 }
 
 - (void)extensionViewFrameChanged {
   [self adjustExtensionViewSize];
   [self infobar]->SetBarTargetHeight([self clampedExtensionViewHeight]);
 }
 
 - (CGFloat)clampedExtensionViewHeight {
   CGFloat height = [self delegate]->AsExtensionInfoBarDelegate()->height();
   return std::max(kToolbarMinHeightPx, std::min(height, kToolbarMaxHeightPx));
 }
 
 - (void)adjustExtensionViewSize {
   [extensionView_ setPostsFrameChangedNotifications:NO];
   NSSize extensionViewSize = [extensionView_ frame].size;
-  extensionViewSize.width = NSWidth([window_ frame]);
+  extensionViewSize.width = NSWidth([[self view] frame]);
   extensionViewSize.height = [self clampedExtensionViewHeight];
   [extensionView_ setFrameSize:extensionViewSize];
   [extensionView_ setPostsFrameChangedNotifications:YES];
 }
 
 - (void)setButtonImage:(NSImage*)image {
   [dropdownButton_ setImage:image];
 }
 
 - (void)menuNeedsUpdate:(NSMenu*)menu {
+  DCHECK([self isOwned]);
+
+  if (!contextMenuController_) {
+    extensions::ExtensionHost* extensionHost =
+        [self delegate]->AsExtensionInfoBarDelegate()->extension_host();
+    Browser* browser = chrome::FindBrowserWithWebContents(
+        [self infobar]->OwnerCocoa()->web_contents());
+    contextMenuController_.reset([[ExtensionActionContextMenuController alloc]
+        initWithExtension:extensionHost->extension()
+                  browser:browser
+          extensionAction:NULL]);
+  }
+
   [menu removeAllItems];
   [contextMenuController_ populateMenu:menu];
 }
 
 @end
 
-InfoBar* ExtensionInfoBarDelegate::CreateInfoBar(InfoBarService* owner) {
-  scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(owner, this));
-  NSWindow* window =
-      [(NSView*)owner->web_contents()->GetView()->GetContentNativeView()
-          window];
+// static
+scoped_ptr<InfoBar> ExtensionInfoBarDelegate::CreateInfoBar(
+    scoped_ptr<ExtensionInfoBarDelegate> delegate) {
+  scoped_ptr<InfoBarCocoa> infobar(
+      new InfoBarCocoa(delegate.PassAs<InfoBarDelegate>()));
   base::scoped_nsobject<ExtensionInfoBarController> controller(
-      [[ExtensionInfoBarController alloc] initWithInfoBar:infobar.get()
-                                                   window:window]);
+      [[ExtensionInfoBarController alloc] initWithInfoBar:infobar.get()]);
   infobar->set_controller(controller);
-  return infobar.release();
+  return infobar.PassAs<InfoBar>();
 }