Infobar system refactor.

chrome/browser/google/google_url_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_url_tracker.h"
 
 #include <set>
 #include <string>
 
 #include "base/message_loop/message_loop.h"
@@ skipping 13 matching lines @@
 #include "testing/gtest/include/gtest/gtest.h"
 
 class GoogleURLTrackerTest;
 
 namespace {
 
 // TestInfoBarDelegate --------------------------------------------------------
 
 class TestInfoBarDelegate : public GoogleURLTrackerInfoBarDelegate {
  public:
-  // Creates a test delegate and returns it.  Unlike the parent class, this does
-  // not add the infobar to |infobar_service|, since that "pointer" is really
-  // just a magic number.  Thus there is no InfoBarService ownership of the
-  // returned object; and since the caller doesn't own the returned object, we
-  // rely on |test_harness| cleaning this up eventually in
-  // GoogleURLTrackerTest::OnInfoBarClosed() to avoid leaks.
-  static GoogleURLTrackerInfoBarDelegate* Create(
-      GoogleURLTrackerTest* test_harness,
-      InfoBarService* infobar_service,
-      GoogleURLTracker* google_url_tracker,
-      const GURL& search_url);
+  // Creates a test infobar and delegate and returns the infobar.  Unlike the
+  // parent class, this does not add the infobar to |infobar_service|, since
+  // that "pointer" is really just a magic number.  Thus there is no
+  // InfoBarService ownership of the returned object; and since the caller
+  // doesn't own the returned object, we rely on |test_harness| cleaning this up
+  // eventually in GoogleURLTrackerTest::OnInfoBarClosed() to avoid leaks.
+  static InfoBar* Create(GoogleURLTrackerTest* test_harness,
+                         InfoBarService* infobar_service,
+                         GoogleURLTracker* google_url_tracker,
+                         const GURL& search_url);
 
  private:
   TestInfoBarDelegate(GoogleURLTrackerTest* test_harness,
                       InfoBarService* infobar_service,
                       GoogleURLTracker* google_url_tracker,
                       const GURL& search_url);
   virtual ~TestInfoBarDelegate();
 
   // GoogleURLTrackerInfoBarDelegate:
   virtual void Update(const GURL& search_url) OVERRIDE;
@@ skipping 138 matching lines @@
 // TestInfoBarDelegate above, to make everything continue to work.
 //
 // Technically, the C++98 spec defines the result of casting
 // T* -> intptr_t -> T* to be an identity, but intptr_t -> T* -> intptr_t (what
 // we use here) is "implementation-defined".  Since I've never seen a compiler
 // break this, though, and the result would simply be a failing test rather than
 // a bug in Chrome, we'll use it anyway.
 class GoogleURLTrackerTest : public testing::Test {
  public:
   // Called by TestInfoBarDelegate::Close().
-  void OnInfoBarClosed(scoped_ptr<InfoBarDelegate> infobar,
+  void OnInfoBarClosed(scoped_ptr<InfoBar> infobar,
                        InfoBarService* infobar_service);
 
  protected:
   GoogleURLTrackerTest();
   virtual ~GoogleURLTrackerTest();
 
   // testing::Test
   virtual void SetUp() OVERRIDE;
   virtual void TearDown() OVERRIDE;
 
@@ skipping 20 matching lines @@
   void ExpectDefaultURLs() const;
   void ExpectListeningForCommit(intptr_t unique_id, bool listening);
   bool observer_notified() const { return observer_.notified(); }
   void clear_observer_notified() { observer_.clear_notified(); }
 
  private:
   // Since |infobar_service| is really a magic number rather than an actual
   // object, we don't add the created infobar to it.  Instead we will simulate
   // any helper<->infobar interaction necessary.  The returned object will be
   // cleaned up in OnInfoBarClosed().
-  GoogleURLTrackerInfoBarDelegate* CreateTestInfoBar(
-      InfoBarService* infobar_service,
-      GoogleURLTracker* google_url_tracker,
-      const GURL& search_url);
+  InfoBar* CreateTestInfoBar(InfoBarService* infobar_service,
+                             GoogleURLTracker* google_url_tracker,
+                             const GURL& search_url);
 
   // These are required by the TestURLFetchers GoogleURLTracker will create (see
   // test_url_fetcher_factory.h).
   content::TestBrowserThreadBundle thread_bundle_;
   // Creating this allows us to call
   // net::NetworkChangeNotifier::NotifyObserversOfIPAddressChangeForTests().
   scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
   net::TestURLFetcherFactory fetcher_factory_;
   content::NotificationRegistrar registrar_;
   TestNotificationObserver observer_;
   GoogleURLTrackerNavigationHelper* nav_helper_;
   TestingProfile profile_;
   scoped_ptr<GoogleURLTracker> google_url_tracker_;
   // This tracks the different "tabs" a test has "opened", so we can close them
   // properly before shutting down |google_url_tracker_|, which expects that.
   std::set<int> unique_ids_seen_;
 };
 
-void GoogleURLTrackerTest::OnInfoBarClosed(scoped_ptr<InfoBarDelegate> infobar,
+void GoogleURLTrackerTest::OnInfoBarClosed(scoped_ptr<InfoBar> infobar,
                                            InfoBarService* infobar_service) {
   // First, simulate the InfoBarService firing INFOBAR_REMOVED.
   InfoBar::RemovedDetails removed_details(infobar.get(), false);
   GoogleURLTracker::EntryMap::const_iterator i =
       google_url_tracker_->entry_map_.find(infobar_service);
   ASSERT_FALSE(i == google_url_tracker_->entry_map_.end());
   GoogleURLTrackerMapEntry* map_entry = i->second;
-  ASSERT_EQ(infobar, map_entry->infobar_delegate());
+  ASSERT_EQ(infobar->delegate(), map_entry->infobar_delegate());
   map_entry->Observe(
       chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED,
       content::Source<InfoBarService>(infobar_service),
       content::Details<InfoBar::RemovedDetails>(&removed_details));
 
   // Second, simulate the infobar container closing the infobar in response.
   // This happens automatically as |infobar| goes out of scope.
 }
 
 GoogleURLTrackerTest::GoogleURLTrackerTest()
@@ skipping 156 matching lines @@
                                                     bool listening) {
   GoogleURLTrackerMapEntry* map_entry = GetMapEntry(unique_id);
   if (map_entry) {
     EXPECT_EQ(listening, nav_helper_->IsListeningForNavigationCommit(
         map_entry->navigation_controller()));
   } else {
     EXPECT_FALSE(listening);
   }
 }
 
-GoogleURLTrackerInfoBarDelegate* GoogleURLTrackerTest::CreateTestInfoBar(
+InfoBar* GoogleURLTrackerTest::CreateTestInfoBar(
     InfoBarService* infobar_service,
     GoogleURLTracker* google_url_tracker,
     const GURL& search_url) {
   return TestInfoBarDelegate::Create(this, infobar_service, google_url_tracker,
                                      search_url);
 }
 
 
 // TestInfoBarDelegate --------------------------------------------------------
 
 namespace {
 
 // static
-GoogleURLTrackerInfoBarDelegate* TestInfoBarDelegate::Create(
-    GoogleURLTrackerTest* test_harness,
-    InfoBarService* infobar_service,
-    GoogleURLTracker* google_url_tracker,
-    const GURL& search_url) {
-  return new TestInfoBarDelegate(test_harness, infobar_service,
-                                 google_url_tracker, search_url);
+InfoBar* TestInfoBarDelegate::Create(GoogleURLTrackerTest* test_harness,
+                                     InfoBarService* infobar_service,
+                                     GoogleURLTracker* google_url_tracker,
+                                     const GURL& search_url) {
+  return ConfirmInfoBarDelegate::CreateInfoBar(
+      scoped_ptr<ConfirmInfoBarDelegate>(new TestInfoBarDelegate(
+          test_harness, infobar_service, google_url_tracker,
+          search_url))).release();
 }
 
 TestInfoBarDelegate::TestInfoBarDelegate(GoogleURLTrackerTest* test_harness,
                                          InfoBarService* infobar_service,
                                          GoogleURLTracker* google_url_tracker,
                                          const GURL& search_url)
-  : GoogleURLTrackerInfoBarDelegate(NULL, google_url_tracker, search_url),
+  : GoogleURLTrackerInfoBarDelegate(google_url_tracker, search_url),
     test_harness_(test_harness),
     infobar_service_(infobar_service) {
 }
 
 TestInfoBarDelegate::~TestInfoBarDelegate() {
 }
 
 void TestInfoBarDelegate::Update(const GURL& search_url) {
   set_search_url(search_url);
   set_pending_id(0);
 }
 
 void TestInfoBarDelegate::Close(bool redo_search) {
-  test_harness_->OnInfoBarClosed(scoped_ptr<InfoBarDelegate>(this),
+  test_harness_->OnInfoBarClosed(scoped_ptr<InfoBar>(infobar()),
                                  infobar_service_);
   // WARNING: At this point |this| has been deleted!
 }
 
 }  // namespace
 
 
 // Tests ----------------------------------------------------------------------
 
 TEST_F(GoogleURLTrackerTest, DontFetchWhenNoOneRequestsCheck) {
@@ skipping 574 matching lines @@
   CommitSearch(2, GURL("http://www.google.co.uk/search?q=test2"));
   EXPECT_FALSE(GetInfoBarDelegate(1) == NULL);
   GoogleURLTrackerInfoBarDelegate* delegate2 = GetInfoBarDelegate(2);
   ASSERT_FALSE(delegate2 == NULL);
   SetNavigationPending(1, true);
   ASSERT_NO_FATAL_FAILURE(ExpectListeningForCommit(1, true));
   delegate2->Close(false);
   SetNavigationPending(1, false);
   ASSERT_NO_FATAL_FAILURE(ExpectListeningForCommit(1, false));
 }