Ignore should-scroll-on-main-thread if main frame is not scrollable

Ignore should-scroll-on-main-thread if main frame is not scrollable

The reasons for forcing main frame scrolling are applicable for main frame
scrolling. If we are not scrolling the main frame (and scrolling cannot bubble
to the main frame), we should ignore this hint.

R=aelias@chromium.org,jamesr@chromium.org
BUG=254435
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156727

[Ian Vollick, 2013-08-09 19:46:10]

My attempt at the blink-side approach suggested by aelias@ here
(https://codereview.chromium.org/22567004/).

PTAL when you have a moment.

[Ian Vollick, 2013-08-09 19:58:15]

On 2013/08/09 19:46:10, vollick wrote:
> My attempt at the blink-side approach suggested by aelias@ here
> (https://codereview.chromium.org/22567004/).
> 
> PTAL when you have a moment.

Sorry for the spam. Please hold off on reviewing for the moment. I hope to post
another patch set with a test.

[Ian Vollick, 2013-08-12 19:52:16]

On 2013/08/09 19:58:15, vollick wrote:
> On 2013/08/09 19:46:10, vollick wrote:
> > My attempt at the blink-side approach suggested by aelias@ here
> > (https://codereview.chromium.org/22567004/).
> > 
> > PTAL when you have a moment.
> 
> Sorry for the spam. Please hold off on reviewing for the moment. I hope to
post
> another patch set with a test.

Tests have been added. The patch should be ready for review now.

[aelias_OOO_until_Jul13, 2013-08-12 19:54:09]

lg2m

[jamesr, 2013-08-26 18:17:16]

Code looks good, test doesn't.

https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
File
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt
(right):

https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt:1:
PASS  is undefined.
"PASS  is undefined."? Huh?  Why the 'undefined' string?  Why two spaces after
PASS?

https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
File
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html
(right):

https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html:52:
<script src="../../fast/js/resources/js-test-pre.js"></script>
did you forget to include -post.js?

[Ian Vollick, 2013-08-26 18:59:53]

On 2013/08/26 18:17:16, jamesr wrote:
> Code looks good, test doesn't.
> 
>
https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
> File
>
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt
> (right):
> 
>
https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
>
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt:1:
> PASS  is undefined.
> "PASS  is undefined."? Huh?  Why the 'undefined' string?  Why two spaces after
> PASS?
This was the output from shouldBeUndefined from js-test-pre.js. Admittedly, it's
terrible. In this latest patch, I've included a modified version with better
output.
> 
>
https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
> File
>
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html
> (right):
> 
>
https://codereview.chromium.org/22694003/diff/8001/LayoutTests/compositing/ov...
>
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html:52:
> <script src="../../fast/js/resources/js-test-pre.js"></script>
> did you forget to include -post.js?
Oof. I'm new to -pre.js and didn't realize the -post.js was needed, too. Fixed.

[jamesr, 2013-08-26 19:42:22]

cool, lgtm

[commit-bot: I haz the power, 2013-08-26 20:07:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/22694003/16001

[commit-bot: I haz the power, 2013-08-26 21:53:24]

Change committed as 156727