Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3738)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java

Issue 2269353004: [Android Download] Show a progress bar before backend is loaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@empty
Patch Set: fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
index ed15e8dc7710df511833624e58cbc9bb4626b800..7527007781ac621de15eda03326569125214ebe6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
@@ -42,6 +42,7 @@ import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBri
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.widget.FadingShadow;
import org.chromium.chrome.browser.widget.FadingShadowView;
+import org.chromium.chrome.browser.widget.LoadingView;
import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
import org.chromium.ui.base.DeviceFormFactor;
@@ -117,6 +118,7 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
private final ListView mFilterView;
private final RecyclerView mRecyclerView;
private final View mEmptyView;
+ private final LoadingView mLoadingView;
private BasicNativePage mNativePage;
private final AtomicInteger mNumberOfFilesBeingDeleted = new AtomicInteger();
@@ -131,6 +133,9 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
mEmptyView.setVisibility(View.GONE);
mRecyclerView.setVisibility(View.VISIBLE);
}
+ // At inflation, the RecyclerView is set to gone, and the loading view is visible. As
+ // long as the adapter data changes, we show the recycler view, and hide loading view.
+ mLoadingView.hideLoadingUI();
}
};
@@ -150,6 +155,9 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
mEmptyView = mMainView.findViewById(R.id.empty_view);
+ mLoadingView = (LoadingView) mMainView.findViewById(R.id.loading_view);
+ mLoadingView.showLoadingUI();
+
mSpaceDisplay = new SpaceDisplay(mMainView, mHistoryAdapter);
mHistoryAdapter.registerAdapterDataObserver(mSpaceDisplay);
mSpaceDisplay.onChanged();
@@ -186,8 +194,6 @@ public class DownloadManagerUi implements OnMenuItemClickListener {
}
mToolbar.setTitle(R.string.menu_downloads);
-
- // TODO(ianwen): add support for loading state.
}
/**

Powered by Google App Engine
This is Rietveld 408576698