Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: content/browser/startup_task_runner.h

Issue 22691002: Allow overlapping sync and async startup requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow overlapping sync and async startup requests - fix code review Nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/browser_main_runner.cc ('k') | content/browser/startup_task_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_ 5 #ifndef CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_
6 #define CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_ 6 #define CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/ref_counted.h"
12 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
13 12
14 #include "build/build_config.h" 13 #include "build/build_config.h"
15 14
16 #include "content/public/browser/browser_main_runner.h" 15 #include "content/public/browser/browser_main_runner.h"
17 16
18 namespace content { 17 namespace content {
19 18
20 // A startup task is a void function returning the status on completion. 19 // A startup task is a void function returning the status on completion.
21 // a status of > 0 indicates a failure, and that no further startup tasks should 20 // a status of > 0 indicates a failure, and that no further startup tasks should
22 // be run. 21 // be run.
23 typedef base::Callback<int(void)> StartupTask; 22 typedef base::Callback<int(void)> StartupTask;
24 23
25 // This class runs startup tasks. The tasks are either run immediately inline, 24 // This class runs startup tasks. The tasks are either run immediately inline,
26 // or are queued one at a time on the UI thread's message loop. If the events 25 // or are queued one at a time on the UI thread's message loop. If the events
27 // are queued, UI events that are received during startup will be acted upon 26 // are queued, UI events that are received during startup will be acted upon
28 // between startup tasks. The motivation for this is that, on targets where the 27 // between startup tasks. The motivation for this is that, on targets where the
29 // UI is already started, it allows us to keep the UI responsive during startup. 28 // UI is already started, it allows us to keep the UI responsive during startup.
30 // 29 //
31 // Note that this differs from a SingleThreadedTaskRunner in that there may be 30 // Note that this differs from a SingleThreadedTaskRunner in that there may be
32 // no opportunity to handle UI events between the tasks of a 31 // no opportunity to handle UI events between the tasks of a
33 // SingleThreadedTaskRunner. 32 // SingleThreadedTaskRunner.
34 33
35 class CONTENT_EXPORT StartupTaskRunner 34 class CONTENT_EXPORT StartupTaskRunner {
36 : public base::RefCounted<StartupTaskRunner> {
37 35
38 public: 36 public:
39 // Constructor: Note that |startup_complete_callback| is optional. If it is 37 // Constructor: Note that |startup_complete_callback| is optional. If it is
40 // not null it will be called once all the startup tasks have run. 38 // not null it will be called once all the startup tasks have run.
41 StartupTaskRunner(bool browser_may_start_asynchronously, 39 StartupTaskRunner(base::Callback<void(int)> startup_complete_callback,
42 base::Callback<void(int)> startup_complete_callback,
43 scoped_refptr<base::SingleThreadTaskRunner> proxy); 40 scoped_refptr<base::SingleThreadTaskRunner> proxy);
44 41
42 ~StartupTaskRunner();
43
45 // Add a task to the queue of startup tasks to be run. 44 // Add a task to the queue of startup tasks to be run.
46 virtual void AddTask(StartupTask& callback); 45 void AddTask(StartupTask& callback);
47 46
48 // Start running the tasks. 47 // Start running the tasks asynchronously.
49 virtual void StartRunningTasks(); 48 void StartRunningTasksAsync();
49
50 // Run all tasks, or all remaining tasks, synchronously
51 void RunAllTasksNow();
50 52
51 private: 53 private:
52 friend class base::RefCounted<StartupTaskRunner>; 54 friend class base::RefCounted<StartupTaskRunner>;
53 virtual ~StartupTaskRunner();
54 55
55 std::list<StartupTask> task_list_; 56 std::list<StartupTask> task_list_;
56 void WrappedTask(); 57 void WrappedTask();
57 58
58 const bool asynchronous_startup_;
59 base::Callback<void(int)> startup_complete_callback_; 59 base::Callback<void(int)> startup_complete_callback_;
60 scoped_refptr<base::SingleThreadTaskRunner> proxy_; 60 scoped_refptr<base::SingleThreadTaskRunner> proxy_;
61 61
62 DISALLOW_COPY_AND_ASSIGN(StartupTaskRunner); 62 DISALLOW_COPY_AND_ASSIGN(StartupTaskRunner);
63 }; 63 };
64 64
65 } // namespace content 65 } // namespace content
66 #endif // CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_ 66 #endif // CONTENT_BROWSER_STARTUP_TASK_RUNNER_H_
OLDNEW
« no previous file with comments | « content/browser/browser_main_runner.cc ('k') | content/browser/startup_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698