Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 22681006: SkPath: fix rFooTo() methods following close() (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, reed1
Visibility:
Public.

Description

All rSomethingTo() immediately following a close() are relative to the point we closed from, not the point we close to. Fix that. Seems like this has been broken since the stone ages. BUG=skia:1474 , code.google.com/p/android/issues/detail?id=41216 Committed: http://code.google.com/p/skia/source/detail?r=10666

Patch Set 1 #

Patch Set 2 : found real problem #

Patch Set 3 : clean up import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M src/core/SkPath.cpp View 1 4 chunks +4 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 2 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
7 years, 4 months ago (2013-08-09 19:13:52 UTC) #1
bsalomon
LGTM, but I think we should consider making close() store the close point so that ...
7 years, 4 months ago (2013-08-09 19:36:29 UTC) #2
mtklein
On 2013/08/09 19:36:29, bsalomon wrote: > LGTM, but I think we should consider making close() ...
7 years, 4 months ago (2013-08-09 19:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/22681006/6001
7 years, 4 months ago (2013-08-09 19:37:34 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 19:48:32 UTC) #5
Message was sent while issue was closed.
Change committed as 10666

Powered by Google App Engine
This is Rietveld 408576698