Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 22680002: Android: uses settask to enable CPU affinity for ADB. (Closed)

Created:
7 years, 4 months ago by bulach
Modified:
7 years, 4 months ago
Reviewers:
navabi1, navabi, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: uses settask to enable CPU affinity for ADB. There are some flakyness in ADB that can potentially be worked around by using a single CPU affinity. This is an experiment for sharded perf tests, it'll probably be reverted soon. BUG=268450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216685

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/android/bb_run_sharded_steps.py View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
7 years, 4 months ago (2013-08-08 14:59:33 UTC) #1
navabi
On 2013/08/08 14:59:33, bulach wrote: > ptal LGTM. I'm interested to see if this helps ...
7 years, 4 months ago (2013-08-08 15:40:03 UTC) #2
bulach
yep.. please see the discussion in the bug, and the linked docs from there :)
7 years, 4 months ago (2013-08-08 15:46:52 UTC) #3
frankf
lgtm https://codereview.chromium.org/22680002/diff/1/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): https://codereview.chromium.org/22680002/diff/1/build/android/bb_run_sharded_steps.py#newcode180 build/android/bb_run_sharded_steps.py:180: cmd_helper.RunCmd(['taskset', '-c', '1', 'adb', 'start-server']) why not -c ...
7 years, 4 months ago (2013-08-08 21:38:09 UTC) #4
bulach
thanks! rebased after reverting the adb trace, addressed the comment, landing. https://codereview.chromium.org/22680002/diff/1/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): ...
7 years, 4 months ago (2013-08-09 09:15:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22680002/8001
7 years, 4 months ago (2013-08-09 09:17:07 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 14:32:13 UTC) #7
Message was sent while issue was closed.
Change committed as 216685

Powered by Google App Engine
This is Rietveld 408576698