content/browser/devtools/render_view_devtools_agent_host.cc - Issue 22674008: DevTools should not try to reattach in Render process is no actual client is connected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.cc

Issue 22674008: DevTools should not try to reattach in Render process is no actual client is connected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/render_view_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_view_devtools_agent_host.cc b/content/browser/devtools/render_view_devtools_agent_host.cc

index 0c2d3238ad62ad18baf81f6766d9b751bbf141ec..efc5242cf3bb1f763b54b57e599586bb507271f6 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.cc

+++ b/content/browser/devtools/render_view_devtools_agent_host.cc

@@ -229,7 +229,7 @@ RenderViewDevToolsAgentHost::~RenderViewDevToolsAgentHost() {

void RenderViewDevToolsAgentHost::AboutToNavigateRenderView(

RenderViewHost* dest_rvh) {

- if (!render_view_host_)

+ if (!render_view_host_ || !IsAttached())

return;

if (render_view_host_ == dest_rvh && static_cast<RenderViewHostImpl*>(

« no previous file with comments | « no previous file | no next file » | no next file with comments »