Make the MR dialog issue banner readable by screen readers

Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f50df8ce43aef2a16e99f63eda9a6c223fc9a9ca
Cr-Commit-Position: refs/heads/master@{#436510}

[takumif, 2016-08-23 00:22:36]

Description was changed from

==========
.

BUG=
==========

to

==========
.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-08-23 17:32:18]

Description was changed from

==========
.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by ChromeVox on ChromeOS

This CL adds an aria-live tag so that the issue text is read when it changes.
This also makes the text selectable by pressing tab, which is another way
ChromeVox can read it.

BUG (internal): b/29458501

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-08-25 01:36:38]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org

[takumif, 2016-08-25 01:36:39]

Please take a look, thanks!

[apacible, 2016-08-25 13:18:26]

For here and in the future - please file a crbug and link to it rather than an
internal bug.

"Assertive" interrupts the user's workflow when there's an issue, whereas
"Polite" waits for the user to be idle. In cases where there are multiple issues
surfaced one after another without user dismissal, how does this sound?

Was this an issue with other screen readers, and if so, does this also resolve
it? If this is a more general fix, please update the patch description to
reflect that.

[apacible, 2016-09-28 17:09:26]

Is this still being worked on?

[takumif, 2016-09-29 01:21:40]

Description was changed from

==========
Make the MR dialog issue banner readable by ChromeVox on ChromeOS

This CL adds an aria-live tag so that the issue text is read when it changes.
This also makes the text selectable by pressing tab, which is another way
ChromeVox can read it.

BUG (internal): b/29458501

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by ChromeVox on ChromeOS

This CL adds an aria-live tag so that the issue text is read when it changes.
This also makes the text selectable by pressing tab, which is another way
ChromeVox can read it.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-09-29 18:38:13]

Thanks for the reminder.

On 2016/08/25 13:18:26, apacible wrote:
> For here and in the future - please file a crbug and link to it rather than an
> internal bug.
Done.

> 
> "Assertive" interrupts the user's workflow when there's an issue, whereas
> "Polite" waits for the user to be idle. In cases where there are multiple
issues
> surfaced one after another without user dismissal, how does this sound?
Yeah, it'd be better for entire issue descriptions to be read. Changing.

> 
> Was this an issue with other screen readers, and if so, does this also resolve
> it? If this is a more general fix, please update the patch description to
> reflect that.
I'm not aware of any other screen readers. Are there any specific ones that we
support?

[apacible, 2016-10-03 17:22:42]

On 2016/09/29 18:38:13, takumif wrote:
> Thanks for the reminder.
> 
> On 2016/08/25 13:18:26, apacible wrote:
> > For here and in the future - please file a crbug and link to it rather than
an
> > internal bug.
> Done.
> 
> > 
> > "Assertive" interrupts the user's workflow when there's an issue, whereas
> > "Polite" waits for the user to be idle. In cases where there are multiple
> issues
> > surfaced one after another without user dismissal, how does this sound?
> Yeah, it'd be better for entire issue descriptions to be read. Changing.
> 
> > 
> > Was this an issue with other screen readers, and if so, does this also
resolve
> > it? If this is a more general fix, please update the patch description to
> > reflect that.
> I'm not aware of any other screen readers. Are there any specific ones that we
> support?

We should also test on Mac with VoiceOver. We've seen some discrepancies between
cvox and VoiceOver in the past. We should also do a sanity check with NVDA/JAWS
on Windows once it lands in Canary.

[takumif, 2016-10-05 23:07:57]

On 2016/10/03 17:22:42, apacible wrote:
> On 2016/09/29 18:38:13, takumif wrote:
> > Thanks for the reminder.
> > 
> > On 2016/08/25 13:18:26, apacible wrote:
> > > For here and in the future - please file a crbug and link to it rather
than
> an
> > > internal bug.
> > Done.
> > 
> > > 
> > > "Assertive" interrupts the user's workflow when there's an issue, whereas
> > > "Polite" waits for the user to be idle. In cases where there are multiple
> > issues
> > > surfaced one after another without user dismissal, how does this sound?
> > Yeah, it'd be better for entire issue descriptions to be read. Changing.
> > 
> > > 
> > > Was this an issue with other screen readers, and if so, does this also
> resolve
> > > it? If this is a more general fix, please update the patch description to
> > > reflect that.
> > I'm not aware of any other screen readers. Are there any specific ones that
we
> > support?
> 
> We should also test on Mac with VoiceOver. We've seen some discrepancies
between
> cvox and VoiceOver in the past. We should also do a sanity check with
NVDA/JAWS
> on Windows once it lands in Canary.

Tested on NVDA and VoiceOver. The aria-live attribute doesn't work. This seems
to be because we're in a dialog.
I thought it might be because the elements are in shadow-DOMs, but that's not
the case. The aria-live attribute works fine in shadow-DOMs on normal web pages.

The issue banner can be read by tabbing to it (which will be better than the
current situation in which it can't be read at all), but users won't be notified
when the banner appears.

[apacible, 2016-10-28 02:47:40]

On 2016/10/05 23:07:57, takumif wrote:
> On 2016/10/03 17:22:42, apacible wrote:
> > On 2016/09/29 18:38:13, takumif wrote:
> > > Thanks for the reminder.
> > > 
> > > On 2016/08/25 13:18:26, apacible wrote:
> > > > For here and in the future - please file a crbug and link to it rather
> than
> > an
> > > > internal bug.
> > > Done.
> > > 
> > > > 
> > > > "Assertive" interrupts the user's workflow when there's an issue,
whereas
> > > > "Polite" waits for the user to be idle. In cases where there are
multiple
> > > issues
> > > > surfaced one after another without user dismissal, how does this sound?
> > > Yeah, it'd be better for entire issue descriptions to be read. Changing.
> > > 
> > > > 
> > > > Was this an issue with other screen readers, and if so, does this also
> > resolve
> > > > it? If this is a more general fix, please update the patch description
to
> > > > reflect that.
> > > I'm not aware of any other screen readers. Are there any specific ones
that
> we
> > > support?
> > 
> > We should also test on Mac with VoiceOver. We've seen some discrepancies
> between
> > cvox and VoiceOver in the past. We should also do a sanity check with
> NVDA/JAWS
> > on Windows once it lands in Canary.
> 
> Tested on NVDA and VoiceOver. The aria-live attribute doesn't work. This seems
> to be because we're in a dialog.
> I thought it might be because the elements are in shadow-DOMs, but that's not
> the case. The aria-live attribute works fine in shadow-DOMs on normal web
pages.
Could you ping the folks more familiar with this space to see if there's
something we can do here? Either use the existing bug (for general screen reader
usage) or file a new crbug to track the progress.

> The issue banner can be read by tabbing to it (which will be better than the
> current situation in which it can't be read at all), but users won't be
notified
> when the banner appears.
Ack.

[apacible, 2016-10-28 02:49:14]

LGTM

Please update the title/description to be more general (i.e. screen reader
friendly besides chromevox on cros) as well as mention the aria-live issues.

[takumif, 2016-10-31 18:34:51]

Description was changed from

==========
Make the MR dialog issue banner readable by ChromeVox on ChromeOS

This CL adds an aria-live tag so that the issue text is read when it changes.
This also makes the text selectable by pressing tab, which is another way
ChromeVox can read it.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-10-31 18:37:29]

On 2016/10/28 02:47:40, apacible wrote:
> On 2016/10/05 23:07:57, takumif wrote:
> > On 2016/10/03 17:22:42, apacible wrote:
> > > On 2016/09/29 18:38:13, takumif wrote:
> > > > Thanks for the reminder.
> > > > 
> > > > On 2016/08/25 13:18:26, apacible wrote:
> > > > > For here and in the future - please file a crbug and link to it rather
> > than
> > > an
> > > > > internal bug.
> > > > Done.
> > > > 
> > > > > 
> > > > > "Assertive" interrupts the user's workflow when there's an issue,
> whereas
> > > > > "Polite" waits for the user to be idle. In cases where there are
> multiple
> > > > issues
> > > > > surfaced one after another without user dismissal, how does this
sound?
> > > > Yeah, it'd be better for entire issue descriptions to be read. Changing.
> > > > 
> > > > > 
> > > > > Was this an issue with other screen readers, and if so, does this also
> > > resolve
> > > > > it? If this is a more general fix, please update the patch description
> to
> > > > > reflect that.
> > > > I'm not aware of any other screen readers. Are there any specific ones
> that
> > we
> > > > support?
> > > 
> > > We should also test on Mac with VoiceOver. We've seen some discrepancies
> > between
> > > cvox and VoiceOver in the past. We should also do a sanity check with
> > NVDA/JAWS
> > > on Windows once it lands in Canary.
> > 
> > Tested on NVDA and VoiceOver. The aria-live attribute doesn't work. This
seems
> > to be because we're in a dialog.
> > I thought it might be because the elements are in shadow-DOMs, but that's
not
> > the case. The aria-live attribute works fine in shadow-DOMs on normal web
> pages.
> Could you ping the folks more familiar with this space to see if there's
> something we can do here? Either use the existing bug (for general screen
reader
> usage) or file a new crbug to track the progress.

I see that the print preview dialog also uses aria-live attributes, but am not
sure how I can trigger them to see if they work. What would be a good group to
ask about this?

> 
> > The issue banner can be read by tabbing to it (which will be better than the
> > current situation in which it can't be read at all), but users won't be
> notified
> > when the banner appears.
> Ack.

[apacible, 2016-10-31 18:44:51]

> I see that the print preview dialog also uses aria-live attributes, but am not
> sure how I can trigger them to see if they work. What would be a good group to
> ask about this?
I recommend reaching out to the print preview owners:
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/O...

[apacible, 2016-10-31 18:51:35]

Clarifying that a bit -- print preview folks (especially on their WebUI) may
have run into this issue before, since they're working in the same constrained
dialog with Polymer. Other folks who may be knowledgeable include our a11y team
(e.g. aboxhall@), or Polymer in Chrome/WebUI team (i.e. dbeam@, michaelpg@).
However, they may not have experience with this specific case. :)

[takumif, 2016-11-14 19:19:52]

Description was changed from

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-11-15 00:27:45]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:49:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[takumif, 2016-11-15 04:16:20]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 04:16:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 05:24:42]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-06 01:38:54]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:33:03]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-06 03:24:27]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-12-06 03:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 03:29:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480994667771820,
"parent_rev": "4649cf0cea025755b51341ebff20e2bb330ee570", "commit_rev":
"199271ab958211e67945678af8985d224c7cbece"}

[commit-bot: I haz the power, 2016-12-06 03:29:53]

Description was changed from

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-06 03:29:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 03:31:38]

Description was changed from

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make the MR dialog issue banner readable by screen readers

This CL makes the text in issue banners selectable by pressing tab, which allows
screen readers to read the text. This CL also adds aria-live attribute to the
text, but it is currently not functional.

BUG=651277

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f50df8ce43aef2a16e99f63eda9a6c223fc9a9ca
Cr-Commit-Position: refs/heads/master@{#436510}
==========

[commit-bot: I haz the power, 2016-12-06 03:31:39]

Patchset 2 (id:??) landed as
https://crrev.com/f50df8ce43aef2a16e99f63eda9a6c223fc9a9ca
Cr-Commit-Position: refs/heads/master@{#436510}