Add additional validation to swarming v1 distributor.

Add additional validation to swarming v1 distributor.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=637977, 639975
Committed: https://github.com/luci/luci-go/commit/4f790ea35e325c27020be41b793774ffd708a5c0

[iannucci, 2016-08-22 22:26:54]

Description was changed from

==========
Add additional validation to swarming v1 distributor.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=637977
==========

to

==========
Add additional validation to swarming v1 distributor.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=637977,639975
==========

[iannucci, 2016-08-22 22:27:10]

PTAL, just some additional validation checks

[Vadim Sh., 2016-08-22 22:32:42]

lgtm

https://chromiumcodereview.appspot.com/2267143002/diff/1/dm/api/distributor/s...
File dm/api/distributor/swarming/v1/normalize.go (right):

https://chromiumcodereview.appspot.com/2267143002/diff/1/dm/api/distributor/s...
dm/api/distributor/swarming/v1/normalize.go:110: if u.Scheme != "http" &&
u.Scheme != "https" {
I thought you were against specifying URLs instead of just host names.

https://chromiumcodereview.appspot.com/2267143002/diff/1/dm/api/distributor/s...
dm/api/distributor/swarming/v1/normalize.go:113: if fmt.Sprintf("%s://%s",
u.Scheme, u.Host) != uStr {
is custom port (if any) part of u.Host?

[iannucci, 2016-08-26 00:20:01]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-08-26 00:20:05]

https://codereview.chromium.org/2267143002/diff/1/dm/api/distributor/swarming...
File dm/api/distributor/swarming/v1/normalize.go (right):

https://codereview.chromium.org/2267143002/diff/1/dm/api/distributor/swarming...
dm/api/distributor/swarming/v1/normalize.go:110: if u.Scheme != "http" &&
u.Scheme != "https" {
On 2016/08/22 at 22:32:42, Vadim Sh. wrote:
> I thought you were against specifying URLs instead of just host names.

you convinced me otherwise :)

https://codereview.chromium.org/2267143002/diff/1/dm/api/distributor/swarming...
dm/api/distributor/swarming/v1/normalize.go:113: if fmt.Sprintf("%s://%s",
u.Scheme, u.Host) != uStr {
On 2016/08/22 at 22:32:42, Vadim Sh. wrote:
> is custom port (if any) part of u.Host?

yep (I just checked): https://golang.org/pkg/net/url/#URL

[commit-bot: I haz the power, 2016-08-26 00:20:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:22:01]

Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30dd09983bc7bf10)
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30dd099836c56d10)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30dd09983fb5b910)

[iannucci, 2016-08-26 00:24:49]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-08-26 00:24:49]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2267143002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-26 00:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:32:47]

Description was changed from

==========
Add additional validation to swarming v1 distributor.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=637977,639975
==========

to

==========
Add additional validation to swarming v1 distributor.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=637977,639975

Committed:
https://github.com/luci/luci-go/commit/4f790ea35e325c27020be41b793774ffd708a5c0
==========

[commit-bot: I haz the power, 2016-08-26 00:32:48]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/4f790ea35e325c27020be41b793774ffd708a5c0