Issue 2266253002: Revert "Record the offscreen playing duration of autoplaying muted videos"

Issue 2266253002: Revert "Record the offscreen playing duration of autoplaying muted videos" (Closed)

Created:
4 years, 3 months ago by megjablon

Modified:
4 years, 3 months ago

Reviewers:
Ilya Sherman, mlamouri (slow - plz ping)

CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, blink-reviews-html_chromium.org, eric.carlson_apple.com, mlamouri+watch-blink_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Record the offscreen playing duration of autoplaying muted videos" This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c. Tests failing on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak: media/autoplay-muted.html media/autoplay-unmute-offscreen.html media/autoplay-when-visible.html 15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked 15:30:48.155 15954 Xlib: extension "RANDR" missing on display ":9". 15:30:48.155 15954 Xlib: extension "RANDR" missing on display ":9". 15:30:48.155 15954 [4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource 15:30:48.155 15954 [4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using MultibufferDataSource 15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})) 15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed: 15:30:48.157 15954 worker/3 leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}) TBR=isherman@chromium.org, mlamouri@chromium.org BUG=617681 Committed: https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772 Cr-Commit-Position: refs/heads/master@{#413635}

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -186 lines)			Patch
M	third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/AutoplayUmaHelper.h	View	2 chunks	+4 lines, -38 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp	View	6 chunks	+33 lines, -121 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 7 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

megjablon

Description was changed from ========== Revert "Record the offscreen playing duration of autoplaying muted videos" ...

4 years, 3 months ago (2016-08-22 22:55:18 UTC) #1

Description was changed from

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681
==========

to

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266253002/1

4 years, 3 months ago (2016-08-22 22:56:23 UTC) #3

commit-bot: I haz the power

Description was changed from ========== Revert "Record the offscreen playing duration of autoplaying muted videos" ...

4 years, 3 months ago (2016-08-23 02:12:53 UTC) #4

Message was sent while issue was closed.

Description was changed from

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681
==========

to

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681
==========

commit-bot: I haz the power

Description was changed from ========== Revert "Record the offscreen playing duration of autoplaying muted videos" ...

4 years, 3 months ago (2016-08-23 02:14:46 UTC) #6

Message was sent while issue was closed.

Description was changed from

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681
==========

to

==========
Revert "Record the offscreen playing duration of autoplaying muted videos"

This reverts commit cc74c3a6422be9a25c635021a57f7f0950c0381c.

Tests failing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak:
media/autoplay-muted.html
media/autoplay-unmute-offscreen.html
media/autoplay-when-visible.html

15:30:48.155 15954 worker/3 media/autoplay-unmute-offscreen.html leaked
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954   Xlib:  extension "RANDR" missing on display ":9".
15:30:48.155 15954  
[4:4:0822/153047:2028208541:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.155 15954  
[4:4:0822/153047:2028209045:WARNING:webmediaplayer_impl.cc(372)] Using
MultibufferDataSource
15:30:48.158 18115 [35/36] media/autoplay-unmute-offscreen.html failed
unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]}))
15:30:48.157 15954 worker/3 media/autoplay-unmute-offscreen.html failed:
15:30:48.157 15954 worker/3  leak detected:
({"numberOfLiveActiveDOMObjects":[2,3]})

TBR=isherman@chromium.org, mlamouri@chromium.org
BUG=617681

Committed: https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772
Cr-Commit-Position: refs/heads/master@{#413635}
==========

commit-bot: I haz the power

4 years, 3 months ago (2016-08-23 02:14:48 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/36d7422fbb9f27d2a931e91edcabe473a2d55772
Cr-Commit-Position: refs/heads/master@{#413635}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages