Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: media/cdm/cdm_wrapper.h

Issue 2265893003: media: Add UMA to report CDM interface version being used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cdm/ppapi/ppapi_cdm_adapter.cc » ('j') | media/cdm/ppapi/ppapi_cdm_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/cdm_wrapper.h
diff --git a/media/cdm/cdm_wrapper.h b/media/cdm/cdm_wrapper.h
index 20cdaad61344ec7e8ac8d9fb372eb6048571ef6b..01ef2db09e20e950b5218e0bb6bd4ad25c850c9c 100644
--- a/media/cdm/cdm_wrapper.h
+++ b/media/cdm/cdm_wrapper.h
@@ -58,7 +58,10 @@ class CdmWrapper {
GetCdmHostFunc get_cdm_host_func,
void* user_data);
- virtual ~CdmWrapper(){};
+ virtual ~CdmWrapper() {}
+
+ // Returns the version of the CDM interface that the created CDM uses.
+ virtual int GetVersion() = 0;
ddorwin 2016/08/22 20:38:15 Get*API*Version or something like that. (In theory
xhwang 2016/08/23 00:21:43 Done.
virtual void Initialize(bool allow_distinctive_identifier,
bool allow_persistent_state) = 0;
@@ -137,6 +140,8 @@ class CdmWrapperImpl : public CdmWrapper {
~CdmWrapperImpl() override { cdm_->Destroy(); }
+ int GetVersion() override { return CdmInterface::kVersion; }
+
void Initialize(bool allow_distinctive_identifier,
bool allow_persistent_state) override {
cdm_->Initialize(allow_distinctive_identifier, allow_persistent_state);
« no previous file with comments | « no previous file | media/cdm/ppapi/ppapi_cdm_adapter.cc » ('j') | media/cdm/ppapi/ppapi_cdm_adapter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698