net/proxy/proxy_script_fetcher_impl.h - Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_script_fetcher_impl.h

Issue 2265873002: Adjust callers and networking delegates in net/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: rebased on top of URLRequest::Read CL Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_script_fetcher_impl.h

diff --git a/net/proxy/proxy_script_fetcher_impl.h b/net/proxy/proxy_script_fetcher_impl.h

index 0ece5b8fbaef1259fe74a3d36977353a2214d87d..4cb08aca88dd026116c1977a65d7899785e2cc32 100644

--- a/net/proxy/proxy_script_fetcher_impl.h

+++ b/net/proxy/proxy_script_fetcher_impl.h

@@ -44,7 +44,7 @@ class NET_EXPORT ProxyScriptFetcherImpl : public ProxyScriptFetcher,

base::TimeDelta SetTimeoutConstraint(base::TimeDelta timeout);

size_t SetSizeConstraint(size_t size_bytes);

- void OnResponseCompleted(URLRequest* request);

+ void OnResponseCompleted(URLRequest* request, int net_error);

// ProxyScriptFetcher methods:

int Fetch(const GURL& url,

@@ -59,7 +59,7 @@ class NET_EXPORT ProxyScriptFetcherImpl : public ProxyScriptFetcher,

void OnSSLCertificateError(URLRequest* request,

const SSLInfo& ssl_info,

bool is_hsts_ok) override;

- void OnResponseStarted(URLRequest* request) override;

+ void OnResponseStarted(URLRequest* request, int net_error) override;

void OnReadCompleted(URLRequest* request, int num_bytes) override;

private:

« no previous file with comments | « net/proxy/network_delegate_error_observer_unittest.cc ('k') | net/proxy/proxy_script_fetcher_impl.cc » ('j') | no next file with comments »