Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: recipe_modules/step/config.py

Issue 2265673002: Add LogDog / annotation protobuf support. (Closed) Base URL: https://github.com/luci/recipes-py@step-formal-struct
Patch Set: Code review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The LUCI Authors. All rights reserved. 1 # Copyright 2013 The LUCI Authors. All rights reserved.
2 # Use of this source code is governed under the Apache License, Version 2.0 2 # Use of this source code is governed under the Apache License, Version 2.0
3 # that can be found in the LICENSE file. 3 # that can be found in the LICENSE file.
4 4
5 import collections 5 import collections
6 6
7 from recipe_engine.config import (config_item_context, ConfigGroup, ConfigList, 7 from recipe_engine.config import (config_item_context, ConfigGroup, ConfigList,
8 Dict, Single, Set, List) 8 Dict, Single, Set, List)
9 from recipe_engine.config_types import Path 9 from recipe_engine.config_types import Path
10 from recipe_engine.util import Placeholder 10 from recipe_engine.util import Placeholder
11 11
12 12
13 def BaseConfig(**_kwargs): 13 def BaseConfig(**_kwargs):
14 def render_cmd(lst): 14 def render_cmd(lst):
15 return [(x if isinstance(x, Placeholder) else str(x)) for x in lst] 15 return [(x if isinstance(x, Placeholder) else str(x)) for x in lst]
16 16
17 return ConfigGroup( 17 return ConfigGroup(
18 # For compatibility with buildbot, the step name must be ascii, which is why 18 # For compatibility with buildbot, the step name must be ascii, which is why
19 # this is a 'str' and not a 'basestring'. 19 # this is a 'str' and not a 'basestring'.
20 name = Single(str), 20 name = Single(str),
21 base_name = Single(str, required=False),
21 cmd = List(inner_type=(int,long,basestring,Path,Placeholder), 22 cmd = List(inner_type=(int,long,basestring,Path,Placeholder),
22 jsonish_fn=render_cmd), 23 jsonish_fn=render_cmd),
23 timeout = Single(int, required=False), 24 timeout = Single(int, required=False),
24 25
25 # optional 26 # optional
26 env = Dict(item_fn=lambda (k, v): (k, v if v is None else str(v)), 27 env = Dict(item_fn=lambda (k, v): (k, v if v is None else str(v)),
27 value_type=(basestring,int,Path,type(None))), 28 value_type=(basestring,int,Path,type(None))),
28 cwd = Single(Path, jsonish_fn=str, required=True), 29 cwd = Single(Path, jsonish_fn=str, required=True),
29 30
30 stdout = Single(Placeholder, required=False), 31 stdout = Single(Placeholder, required=False),
(...skipping 19 matching lines...) Expand all
50 step_nest_level = Single(int, required=False), 51 step_nest_level = Single(int, required=False),
51 ) 52 )
52 53
53 54
54 config_ctx = config_item_context(BaseConfig) 55 config_ctx = config_item_context(BaseConfig)
55 56
56 @config_ctx() 57 @config_ctx()
57 def test(c): # pragma: no cover 58 def test(c): # pragma: no cover
58 c.name = 'test' 59 c.name = 'test'
59 c.cmd = [Path('[CHECKOUT]', 'build', 'tools', 'cool_script.py')] 60 c.cmd = [Path('[CHECKOUT]', 'build', 'tools', 'cool_script.py')]
OLDNEW
« recipe_engine/stream_logdog.py ('K') | « recipe_modules/step/api.py ('k') | recipes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698