Issue 22650009: fix path issues on mac and win for skpdiff_server.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22650009: fix path issues on mac and win for skpdiff_server.py (Closed)

Created:
7 years, 4 months ago by Zach Reizner

Modified:
7 years, 4 months ago

Reviewers:
jvanverth1, epoger, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix path issues on mac and win for skpdiff_server.py Committed: http://code.google.com/p/skia/source/detail?r=10719

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tools/skpdiff/skpdiff_server.py	View		3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

lgtm Looking at https://code.google.com/p/skia/source/browse/trunk/tools/skpdiff/skpdiff_server.py , it seems that this was not committed yet. Sending to ...

7 years, 4 months ago (2013-08-14 18:51:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zachr@google.com/22650009/1

7 years, 4 months ago (2013-08-14 18:51:55 UTC) #4

Message was sent while issue was closed.

Change committed as 10719

Expand Messages | Collapse Messages