Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 22650007: Fix crash when querying a runtime config that is defined in environment (Closed)

Created:
7 years, 4 months ago by Kimmo Kinnunen
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix crash when querying a runtime config that is defined in environment Fix crash when querying a runtime config in case when there's no skia.conf file and the config variable is still defined in the environment. Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test. BUG=skia:1494 Committed: http://code.google.com/p/skia/source/detail?r=10654

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkRTConf.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/utils/SkRTConf.cpp View 4 chunks +22 lines, -0 lines 0 comments Download
A tests/UnitTestTest.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kimmo Kinnunen
r? Brian as you reviewed the original commit
7 years, 4 months ago (2013-08-09 08:27:47 UTC) #1
bsalomon
lgtm. Greg, adding you to list in case you want to do an after-the-fact review.
7 years, 4 months ago (2013-08-09 13:14:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/22650007/4001
7 years, 4 months ago (2013-08-09 13:14:40 UTC) #3
commit-bot: I haz the power
Change committed as 10654
7 years, 4 months ago (2013-08-09 13:23:58 UTC) #4
robertphillips
7 years, 4 months ago (2013-08-12 12:07:22 UTC) #5
Message was sent while issue was closed.
This was reverted in 10669 due to Chromium Windows failures:

win:
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/100045/ste...
win_layout:
http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/790...
win_gpu:
http://build.chromium.org/p/tryserver.chromium/builders/win_gpu/builds/1742/s...

[254/3668] CXX obj\third_party\skia\src\core\skia.skpicture.obj
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma\gomacc.exe
"c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\cl.exe" /nologo
/showIncludes /FC @obj\third_party\skia\src\utils\skia.skrtconf.obj.rsp /c
..\..\third_party\skia\src\utils\SkRTConf.cpp
/Foobj\third_party\skia\src\utils\skia.skrtconf.obj /Fdobj\skia\skia.pdb 
e:\b\build\slave\win_layout\build\src\third_party\skia\src\utils\skrtconf.cpp(309)
: error C3861: 'setenv': identifier not found
ninja: build stopped: subcommand failed.

Powered by Google App Engine
This is Rietveld 408576698