gpu/command_buffer/client/gles2_implementation_unittest.cc - Issue 226483003: Flag INV_OP during BeginQuery if id is not obtained from GenQueriesEXT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 226483003: Flag INV_OP during BeginQuery if id is not obtained from GenQueriesEXT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: service side check for generated query ids. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/gles2_implementation_unittest.cc

diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc

index afb31bd0893102e548b4dfb18a864b87774bffb0..cb7f6bdddb73d9a9636770c79ad7381d1c04f08a 100644

--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc

+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc

@@ -2906,9 +2906,6 @@ TEST_F(GLES2ImplementationTest, BeginEndQueryEXT) {

EXPECT_TRUE(NoCommandsWritten());

EXPECT_EQ(GL_INVALID_OPERATION, CheckError());

- // Test BeginQueryEXT fails if id not GENed.

- // TODO(gman):

rptr 2014/04/19 11:48:45 Check for invalid query id is now in service side.

// Test BeginQueryEXT inserts command.

struct BeginCmds {

cmds::BeginQueryEXT begin_query;

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')