Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2264753002:
Update WebAPK using downloaded apk. (Closed)
DescriptionUpdate WebAPK using downloaded apk.
After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL
enables to install the downloaded WebAPK to finish the updating.
This CL depends on CL (https://codereview.chromium.org/2259553002/).
BUG=631025, 637097
Committed: https://crrev.com/47b2313b91606860aa38e09910cdecb7400d1df3
Cr-Commit-Position: refs/heads/master@{#415772}
Patch Set 1 #Patch Set 2 : Update: install downloaded apk. #Patch Set 3 : Rebase. #Patch Set 4 : Rebase. #Patch Set 5 : Fix compiling error. #Messages
Total messages: 29 (15 generated)
hanxi@chromium.org changed reviewers: + pkotwicz@chromium.org
Hi Peter, with this patch, the WebAPK's updating finally works. Could you please take a look? Thanks!
Description was changed from ========== Update WebAPK using downloaded apk. BUG=631025 ========== to ========== Update WebAPK using downloaded apk. BUG=631025 ==========
hanxi@chromium.org changed reviewers: + yfriedman@chromium.org
Passing this one onto Yaron.
On 2016/08/19 23:39:15, pkotwicz wrote: > Passing this one onto Yaron. lgtm but please also add 637097 to the bug list. One of us will also have to rebase cause this conflicts: https://codereview.chromium.org/2247183008/
Forgot that one. I will rebase on your CL.
Description was changed from ========== Update WebAPK using downloaded apk. BUG=631025 ========== to ========== Update WebAPK using downloaded apk. BUG=631025, 637097 ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Update WebAPK using downloaded apk. BUG=631025, 637097 ========== to ========== Update WebAPK using downloaded apk. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ==========
Hi Peter, I didn't add the check to compare the new WebAPK version V.S. the old one. This is because I don't think it is right to return success = false when the WebAPK is installed but the version number isn't increased. Currently the callback of the UpdataAsync() is to update the timestamps in WebappDataStorage, and it seems not right to store a failure for the above case, which may cause requesting a check for update again soon. What do you think?
For https://codereview.chromium.org/2259553002/ (the app banner CL) to be correct the callback should be called only after the update finishes and should return a failure status if the update failed for whatever reason. Since the code in WebApkInstaller.java is temporary I don't mind if you add a TODO in https://codereview.chromium.org/2259553002/
I added a TODO on the "app banner" CL. PTAL, thanks!
Description was changed from ========== Update WebAPK using downloaded apk. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ========== to ========== Update WebAPK using downloaded apk. After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ==========
hanxi@chromium.org changed reviewers: + dfalcantara@chromium.org
Hi Dan, Peter is on vacation and Yaron is OOO, could you please take a look? Thanks!
lgtm
The CQ bit was checked by hanxi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, dfalcantara@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/2264753002/#ps80001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by hanxi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2264753002/#ps100001 (title: "Fix compiling error.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update WebAPK using downloaded apk. After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ========== to ========== Update WebAPK using downloaded apk. After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Update WebAPK using downloaded apk. After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 ========== to ========== Update WebAPK using downloaded apk. After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 Committed: https://crrev.com/47b2313b91606860aa38e09910cdecb7400d1df3 Cr-Commit-Position: refs/heads/master@{#415772} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/47b2313b91606860aa38e09910cdecb7400d1df3 Cr-Commit-Position: refs/heads/master@{#415772} |
