Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(81)

Issue 22645007: Remove superfluous min calls in RenderBlock::computeOverflow. (Closed)

Created:
7 years ago by jbroman
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, danakj
Visibility:
Public.

Description

Remove superfluous min calls in RenderBlock::computeOverflow. They are contained in an "if" statement that ensures that textIndent < 0 and so the min will never be 0. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155876

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
This change is extracted from my previous CL. It's a pretty trivial simplification.
7 years ago (2013-08-09 19:24:19 UTC) #1
Julien - ping for review
lgtm
7 years ago (2013-08-09 19:36:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/22645007/4001
7 years ago (2013-08-09 19:36:52 UTC) #3
commit-bot: I haz the power
7 years ago (2013-08-09 22:19:01 UTC) #4
Message was sent while issue was closed.
Change committed as 155876

Powered by Google App Engine
This is Rietveld 408576698