Request profiles info in BrowserOptions.initializePage to populate the profiles list

Request profiles info in BrowserOptions.initializePage to populate the profiles list

Profiles info is being passed to JS in |BrowserOptionsHandler::GetLocalizedValues| which gets called only once when the settings page is opened but not on page reload.
When a user edits in the profiles list (adds or deletes a profile) and then reload the settings page we end up populating the profiles list with old cached data. Accordingly,
we request the profiles info in BrowserOptions.initializePage to get a fresh list of the profiles info every time the page is loaded.

BUG=269942
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216797

[ibra, 2013-08-09 08:49:25]

Hi Bernhard,

Please take a look. Thanks!

[Bernhard Bauer, 2013-08-09 08:57:14]

LGTM with a naming nit:

https://codereview.chromium.org/22642011/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/browser_options_handler.h (right):

https://codereview.chromium.org/22642011/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/browser_options_handler.h:232: void
RequestProfilesInfo(const ListValue* args);
Callbacks are named starting with "Handle" (compare above).

[ibra, 2013-08-09 09:02:26]

https://codereview.chromium.org/22642011/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/browser_options_handler.h (right):

https://codereview.chromium.org/22642011/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/browser_options_handler.h:232: void
RequestProfilesInfo(const ListValue* args);
On 2013/08/09 08:57:14, Bernhard Bauer wrote:
> Callbacks are named starting with "Handle" (compare above).

Done.

[commit-bot: I haz the power, 2013-08-09 09:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22642011/6001

[commit-bot: I haz the power, 2013-08-09 11:10:38]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-09 15:36:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22642011/31001

[commit-bot: I haz the power, 2013-08-09 15:38:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22642011/35004

[ibra, 2013-08-09 15:38:20]

Bernhard, would like to take another look?

[Bernhard Bauer, 2013-08-09 15:42:21]

LGTM still holds, but see the comment suggestion below:

https://codereview.chromium.org/22642011/diff/35004/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/22642011/diff/35004/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:182:
chrome.send('requestProfilesInfo');
Maybe add a comment now that the data we have in loadTimeData might be stale?

[ibra, 2013-08-09 16:29:55]

https://codereview.chromium.org/22642011/diff/35004/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/22642011/diff/35004/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:182:
chrome.send('requestProfilesInfo');
On 2013/08/09 15:42:21, Bernhard Bauer wrote:
> Maybe add a comment now that the data we have in loadTimeData might be stale?

Done.

[commit-bot: I haz the power, 2013-08-09 16:31:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22642011/57001

[commit-bot: I haz the power, 2013-08-10 01:34:20]

Change committed as 216797