Issue 22640007: Add an environment variable override to the default output name

Issue 22640007: Add an environment variable override to the default output name (Closed)

Created:
7 years, 4 months ago by ian_cottrell

Modified:
7 years, 4 months ago

Reviewers:
bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add an environment variable override to the default output name Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216627

Patch Set 2 : Fix indenting #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/pylib/cmd_helper.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! https://codereview.chromium.org/22640007/diff/1/build/android/pylib/cmd_helper.py File build/android/pylib/cmd_helper.py (right): https://codereview.chromium.org/22640007/diff/1/build/android/pylib/cmd_helper.py#newcode104 build/android/pylib/cmd_helper.py:104: os.environ.get('CHROMIUM_OUT_DIR','out')) nit: indent another 2 since it's ...

7 years, 4 months ago (2013-08-08 12:29:58 UTC) #1

ian_cottrell

On 2013/08/08 12:29:58, bulach wrote: > lgtm, thanks! > > https://codereview.chromium.org/22640007/diff/1/build/android/pylib/cmd_helper.py > File build/android/pylib/cmd_helper.py (right): ...

7 years, 4 months ago (2013-08-08 12:42:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/22640007/5001

7 years, 4 months ago (2013-08-08 13:59:03 UTC) #4

Message was sent while issue was closed.

Change committed as 216627

Expand Messages | Collapse Messages