Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 22638017: DevTools: Fix trailing slash in file helper infobar message on windows (should be backslash). (Closed)

Created:
7 years, 4 months ago by vsevik
Modified:
7 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: Fix trailing slash in file helper infobar message on windows (should be backslash). R=pfeldman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216995

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
Please review
7 years, 4 months ago (2013-08-09 11:57:27 UTC) #1
pfeldman
lgtm
7 years, 4 months ago (2013-08-09 15:06:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/22638017/1
7 years, 4 months ago (2013-08-09 15:08:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=185902
7 years, 4 months ago (2013-08-09 22:23:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/22638017/21001
7 years, 4 months ago (2013-08-12 09:21:22 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 15:21:07 UTC) #6
Message was sent while issue was closed.
Change committed as 216995

Powered by Google App Engine
This is Rietveld 408576698