Views Textfield: multiple clicks should alternate between double and triple click behavior

Views Textfield: multiple clicks should alternate between double and triple click behavior

Currently, consecutive clicks will produce this behavior: single-click, double-click, triple-click, single-click, double-click, ...
This should match the Win behavior, which is: single-click, double-click, triple-click, double-click, triple-click, ...

BUG=234344
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216914

[msw, 2013-08-09 18:12:11]

LGTM with a comment.

https://codereview.chromium.org/22638016/diff/1/ui/views/controls/textfield/n...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/22638016/diff/1/ui/views/controls/textfield/n...
ui/views/controls/textfield/native_textfield_views.cc:1412: aggregated_clicks_ =
(aggregated_clicks_ % 2) + 1;
nit: Add a comment here explaining how this will yield the intended
double/triple click pattern.

[msw, 2013-08-09 18:15:20]

Oh, also a test would be nice.

[ckocagil, 2013-08-10 15:50:26]

Oh, it turns out we already had a unit test covering this, so I just updated it.

https://codereview.chromium.org/22638016/diff/1/ui/views/controls/textfield/n...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/22638016/diff/1/ui/views/controls/textfield/n...
ui/views/controls/textfield/native_textfield_views.cc:1412: aggregated_clicks_ =
(aggregated_clicks_ % 2) + 1;
On 2013/08/09 18:12:11, msw wrote:
> nit: Add a comment here explaining how this will yield the intended
> double/triple click pattern.

Done.

[msw, 2013-08-10 16:22:40]

Nice, LGTM.

[commit-bot: I haz the power, 2013-08-10 20:53:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/22638016/10001

[commit-bot: I haz the power, 2013-08-12 04:49:38]

Change committed as 216914