Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22638008: DevTools: Use CodeMirror modes instead of highlight tokenizers (Closed)

Created:
7 years, 4 months ago by lushnikov
Modified:
7 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Use CodeMirror modes instead of highlight tokenizers This patch completely removes our generated tokenizers in favor of CodeMirror modes. Removal of TextEditorModel (which is already not used for some time) happens in this patch as well as it produces compilation warnings caused by lack of tokenizers. BUG=260589 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156210

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Total comments: 3

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -8478 lines) Patch
D LayoutTests/inspector/editor/highlighter-basics.html View 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-basics-expected.txt View 1 chunk +0 lines, -141 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-chunk-limit.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-chunk-limit-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-long-line.html View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-long-line-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-paste-in-comment.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-paste-in-comment-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/inspector/editor/highlighter-test.js View 1 chunk +0 lines, -23 lines 0 comments Download
M LayoutTests/inspector/editor/text-editor-mark-clean.html View 1 chunk +37 lines, -37 lines 0 comments Download
D LayoutTests/inspector/editor/text-editor-model.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/inspector/editor/text-editor-model-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/inspector/editor/text-editor-undo-redo.html View 1 chunk +0 lines, -229 lines 0 comments Download
D LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt View 1 chunk +0 lines, -448 lines 0 comments Download
M LayoutTests/inspector/syntax-highlight-css.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/syntax-highlight-css-expected.txt View 3 chunks +14 lines, -14 lines 0 comments Download
M LayoutTests/inspector/syntax-highlight-html-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/syntax-highlight-javascript-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 2 5 chunks +2 lines, -48 lines 0 comments Download
A Source/devtools/front_end/CodeMirrorUtils.js View 1 chunk +102 lines, -0 lines 0 comments Download
M Source/devtools/front_end/DOMSyntaxHighlighter.js View 1 3 chunks +14 lines, -18 lines 0 comments Download
M Source/devtools/front_end/ScriptFormatterWorker.js View 1 2 7 chunks +27 lines, -31 lines 0 comments Download
D Source/devtools/front_end/SourceCSSTokenizer.js View 1 chunk +0 lines, -1571 lines 0 comments Download
D Source/devtools/front_end/SourceCSSTokenizer.re2js View 1 chunk +0 lines, -339 lines 0 comments Download
D Source/devtools/front_end/SourceHTMLTokenizer.js View 1 chunk +0 lines, -816 lines 0 comments Download
D Source/devtools/front_end/SourceHTMLTokenizer.re2js View 1 chunk +0 lines, -391 lines 0 comments Download
D Source/devtools/front_end/SourceJavaScriptTokenizer.js View 1 chunk +0 lines, -2490 lines 0 comments Download
D Source/devtools/front_end/SourceJavaScriptTokenizer.re2js View 1 chunk +0 lines, -210 lines 0 comments Download
D Source/devtools/front_end/SourceTokenizer.js View 1 chunk +0 lines, -128 lines 0 comments Download
D Source/devtools/front_end/TextEditorHighlighter.js View 1 chunk +0 lines, -288 lines 0 comments Download
D Source/devtools/front_end/TextEditorModel.js View 1 chunk +0 lines, -757 lines 0 comments Download
M Source/devtools/front_end/cm/cmdevtools.css View 1 chunk +0 lines, -26 lines 0 comments Download
A Source/devtools/front_end/cm/headlesscodemirror.js View 1 chunk +83 lines, -0 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/inspectorSyntaxHighlight.css View 1 chunk +25 lines, -79 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 2 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lushnikov
Please take a look
7 years, 4 months ago (2013-08-08 14:50:42 UTC) #1
vsevik
https://codereview.chromium.org/22638008/diff/1/Source/devtools/front_end/DOMSyntaxHighlighter.js File Source/devtools/front_end/DOMSyntaxHighlighter.js (right): https://codereview.chromium.org/22638008/diff/1/Source/devtools/front_end/DOMSyntaxHighlighter.js#newcode36 Source/devtools/front_end/DOMSyntaxHighlighter.js:36: if (!WebInspector.CodeMirrorUtils) This is confusing, please remove. https://codereview.chromium.org/22638008/diff/1/Source/devtools/front_end/DOMSyntaxHighlighter.js#newcode62 Source/devtools/front_end/DOMSyntaxHighlighter.js:62: ...
7 years, 4 months ago (2013-08-12 16:36:56 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/22638008/diff/6001/Source/devtools/front_end/ScriptFormatterWorker.js File Source/devtools/front_end/ScriptFormatterWorker.js (right): https://chromiumcodereview.appspot.com/22638008/diff/6001/Source/devtools/front_end/ScriptFormatterWorker.js#newcode91 Source/devtools/front_end/ScriptFormatterWorker.js:91: tokenizer(line, function(tokenValue, tokenType, column, newColumn) { extract https://chromiumcodereview.appspot.com/22638008/diff/6001/Source/devtools/front_end/ScriptFormatterWorker.js#newcode182 Source/devtools/front_end/ScriptFormatterWorker.js:182: ...
7 years, 4 months ago (2013-08-14 16:26:41 UTC) #3
vsevik
lgtm
7 years, 4 months ago (2013-08-14 16:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/22638008/16001
7 years, 4 months ago (2013-08-16 09:40:36 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 12:27:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 156210

Powered by Google App Engine
This is Rietveld 408576698