Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 22637002: Added Action Ignored Logging to the State Machine (Closed)

Created:
7 years, 4 months ago by robliao
Modified:
7 years, 4 months ago
Reviewers:
xiyuan, vadimt
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added Action Ignored Logging to the State Machine Sometimes, when requesting to poll cards, the cards are already being polled (or at least the alarm infrastructure is reporting the alarm is already set). Note that here. BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/google_now/background.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robliao
I found these messages helpful during debugging, especially with the alarms bug.
7 years, 4 months ago (2013-08-07 23:04:59 UTC) #1
vadimt
lgtm
7 years, 4 months ago (2013-08-07 23:28:08 UTC) #2
robliao
xiyuan: Please provide owner approval for this CL. Thanks!
7 years, 4 months ago (2013-08-07 23:29:36 UTC) #3
xiyuan
lgtm
7 years, 4 months ago (2013-08-08 00:47:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/22637002/1
7 years, 4 months ago (2013-08-08 00:53:35 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 07:00:11 UTC) #6
Message was sent while issue was closed.
Change committed as 216619

Powered by Google App Engine
This is Rietveld 408576698