Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/android/webapk/webapk_update_manager.cc

Issue 2263673003: Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_update_manager.cc
diff --git a/chrome/browser/android/webapk/webapk_update_manager.cc b/chrome/browser/android/webapk/webapk_update_manager.cc
index d6e7dbf21319901f7bde75c1be8650575d27e558..78f97df18656fea61b8d53ef3d6c720c06ec3fa4 100644
--- a/chrome/browser/android/webapk/webapk_update_manager.cc
+++ b/chrome/browser/android/webapk/webapk_update_manager.cc
@@ -50,6 +50,7 @@ static void UpdateAsync(JNIEnv* env,
const JavaParamRef<jstring>& java_name,
const JavaParamRef<jstring>& java_short_name,
const JavaParamRef<jstring>& java_icon_url,
+ const JavaParamRef<jstring>& java_icon_murmur2_hash,
const JavaParamRef<jobject>& java_icon_bitmap,
jint java_display_mode,
jint java_orientation,
@@ -86,6 +87,9 @@ static void UpdateAsync(JNIEnv* env,
SkBitmap icon_bitmap = gfx::CreateSkBitmapFromJavaBitmap(java_bitmap_lock);
icon_bitmap.setImmutable();
+ std::string icon_murmur2_hash;
+ ConvertJavaStringToUTF8(env, java_icon_murmur2_hash, &icon_murmur2_hash);
+
std::string webapk_package;
ConvertJavaStringToUTF8(env, java_webapk_package, &webapk_package);
@@ -93,5 +97,5 @@ static void UpdateAsync(JNIEnv* env,
installer->UpdateAsync(
profile,
base::Bind(&WebApkUpdateManager::OnBuiltWebApk, webapk_package),
- webapk_package, java_webapk_version);
+ icon_murmur2_hash, webapk_package, java_webapk_version);
}
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698