Handle the TLS version fallback on the bad_record_mac alert error in

Handle the TLS version fallback on the bad_record_mac alert error in
http_network_transaction.cc, so that it applies to SSLClientSockets
based on both NSS and OpenSSL.

R=agl@chromium.org,rsleevi@chromium.org
BUG=260358
TEST=net_unittests, plus manual testing: visit https://www.web-secured.com/.
Should get a successful TLS 1.0 connection, rather than
ERR_SSL_BAD_RECORD_MAC_ALERT.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216836

[wtc, 2013-08-09 21:19:26]

This is the cleanup that agl mentioned in
http://code.google.com/p/chromium/issues/detail?id=260358#c26

[wtc, 2013-08-09 21:28:31]

https://codereview.chromium.org/22633004/diff/6001/net/http/http_network_tran...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/22633004/diff/6001/net/http/http_network_tran...
net/http/http_network_transaction.cc:1265: version_max--;

We can also change version_max directly to SSL_PROTOCOL_VERSION_TLS1 here.
That'll require checking
   SSL_PROTOCOL_VERSION_TLS1 >= server_ssl_config_.version_min
instead of
    version_max > server_ssl_config_.version_min
on line 1260.

[Ryan Sleevi, 2013-08-09 23:00:57]

lgtm

[commit-bot: I haz the power, 2013-08-09 23:15:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/22633004/6001

[commit-bot: I haz the power, 2013-08-10 13:38:30]

Change committed as 216836