Make URLRequest::Read to return net errors or bytes read instead of a bool

net/url_request/url_request_simple_job_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_simple_job.h"
 
 #include <memory>
 
 #include "base/bind_helpers.h"
 #include "base/macros.h"
@@ skipping 62 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(MockSimpleJob);
 };
 
 class CancelAfterFirstReadURLRequestDelegate : public TestDelegate {
  public:
   CancelAfterFirstReadURLRequestDelegate() : run_loop_(new base::RunLoop) {}
 
   ~CancelAfterFirstReadURLRequestDelegate() override {}
 
-  void OnResponseStarted(URLRequest* request) override {
+  void OnResponseStarted(URLRequest* request, int net_error) override {
+    DCHECK_NE(ERR_IO_PENDING, net_error);
     // net::TestDelegate will start the first read.
-    TestDelegate::OnResponseStarted(request);
+    TestDelegate::OnResponseStarted(request, net_error);
     request->Cancel();
     run_loop_->Quit();
   }
 
   void OnReadCompleted(URLRequest* request, int bytes_read) override {
     // Read should have been cancelled.
-    EXPECT_EQ(-1, bytes_read);
+    EXPECT_EQ(ERR_ABORTED, bytes_read);
   }
 
   void WaitUntilHeadersReceived() const { run_loop_->Run(); }
 
  private:
   std::unique_ptr<base::RunLoop> run_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(CancelAfterFirstReadURLRequestDelegate);
 };
 
@@ skipping 141 matching lines @@
   run_loop.Run();
 
   EXPECT_EQ(URLRequestStatus::CANCELED, request_->status().status());
   EXPECT_EQ(1, cancel_delegate.response_started_count());
   EXPECT_EQ("", cancel_delegate.data_received());
   // Destroy the request so it doesn't outlive its delegate.
   request_.reset();
 }
 
 }  // namespace net