Check if there is no window in LockSystemModalContainer when unlocked.

Check if there is no window in LockSystemModalContainer when unlocked.

BUG=157660
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216870

[James Cook, 2013-08-09 19:08:03]

https://codereview.chromium.org/22626003/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/22626003/diff/1/ash/shell.cc#newcode753
ash/shell.cc:753: DCHECK_EQ(0u, (*iter)->children().size());
Do you want DCHECK or CHECK here?  Are you trying to find problems on actual
devices in the field?

If you stick with DCHECK, maybe wrap this code in #ifdef NDEBUG so we don't do
the loop iteration for a no-op DCHECK.

[oshima, 2013-08-09 20:02:56]

On 2013/08/09 19:08:03, James Cook wrote:
> https://codereview.chromium.org/22626003/diff/1/ash/shell.cc
> File ash/shell.cc (right):
> 
> https://codereview.chromium.org/22626003/diff/1/ash/shell.cc#newcode753
> ash/shell.cc:753: DCHECK_EQ(0u, (*iter)->children().size());
> Do you want DCHECK or CHECK here?  Are you trying to find problems on actual
> devices in the field?
> 
> If you stick with DCHECK, maybe wrap this code in #ifdef NDEBUG so we don't do
> the loop iteration for a no-op DCHECK.

There is no real reports. This is just to catch such issue early in
development/bots.
I prefer _EQ because it gives more info (# of children). I added NDEBUG. PTAL.

[James Cook, 2013-08-09 20:11:39]

Ah, yes, the bots.

LGTM, but did you mean to change the second file?

https://codereview.chromium.org/22626003/diff/7001/net/third_party/nss/ssl/ss...
File net/third_party/nss/ssl/ssl3con.c (right):

https://codereview.chromium.org/22626003/diff/7001/net/third_party/nss/ssl/ss...
net/third_party/nss/ssl/ssl3con.c:52: #ifndef PR_ARRAY_SIZE
Did you mean to change this?

[oshima, 2013-08-09 21:01:19]

On 2013/08/09 20:11:39, James Cook wrote:
> Ah, yes, the bots.
> 
> LGTM, but did you mean to change the second file?
> 
>
https://codereview.chromium.org/22626003/diff/7001/net/third_party/nss/ssl/ss...
> File net/third_party/nss/ssl/ssl3con.c (right):
> 
>
https://codereview.chromium.org/22626003/diff/7001/net/third_party/nss/ssl/ss...
> net/third_party/nss/ssl/ssl3con.c:52: #ifndef PR_ARRAY_SIZE
> Did you mean to change this?

oops, sorry. reverted the file.

[commit-bot: I haz the power, 2013-08-09 21:04:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/22626003/13001

[commit-bot: I haz the power, 2013-08-10 15:30:31]

Change committed as 216870