Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 22623008: Make assert more accurate (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1594 matching lines...) Expand 10 before | Expand all | Expand 10 after
1605 LOperand* right = UseFixed(instr->right(), rax); 1605 LOperand* right = UseFixed(instr->right(), rax);
1606 LCmpT* result = new(zone()) LCmpT(left, right); 1606 LCmpT* result = new(zone()) LCmpT(left, right);
1607 return MarkAsCall(DefineFixed(result, rax), instr); 1607 return MarkAsCall(DefineFixed(result, rax), instr);
1608 } 1608 }
1609 1609
1610 1610
1611 LInstruction* LChunkBuilder::DoCompareNumericAndBranch( 1611 LInstruction* LChunkBuilder::DoCompareNumericAndBranch(
1612 HCompareNumericAndBranch* instr) { 1612 HCompareNumericAndBranch* instr) {
1613 Representation r = instr->representation(); 1613 Representation r = instr->representation();
1614 if (r.IsSmiOrInteger32()) { 1614 if (r.IsSmiOrInteger32()) {
1615 ASSERT(instr->left()->representation().IsSmiOrInteger32()); 1615 ASSERT(instr->left()->representation().Equals(r));
1616 ASSERT(instr->left()->representation().Equals( 1616 ASSERT(instr->right()->representation().Equals(r));
1617 instr->right()->representation()));
1618 LOperand* left = UseRegisterOrConstantAtStart(instr->left()); 1617 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1619 LOperand* right = UseOrConstantAtStart(instr->right()); 1618 LOperand* right = UseOrConstantAtStart(instr->right());
1620 return new(zone()) LCompareNumericAndBranch(left, right); 1619 return new(zone()) LCompareNumericAndBranch(left, right);
1621 } else { 1620 } else {
1622 ASSERT(r.IsDouble()); 1621 ASSERT(r.IsDouble());
1623 ASSERT(instr->left()->representation().IsDouble()); 1622 ASSERT(instr->left()->representation().IsDouble());
1624 ASSERT(instr->right()->representation().IsDouble()); 1623 ASSERT(instr->right()->representation().IsDouble());
1625 LOperand* left; 1624 LOperand* left;
1626 LOperand* right; 1625 LOperand* right;
1627 if (instr->left()->IsConstant() && instr->right()->IsConstant()) { 1626 if (instr->left()->IsConstant() && instr->right()->IsConstant()) {
(...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after
2526 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2525 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2527 LOperand* object = UseRegister(instr->object()); 2526 LOperand* object = UseRegister(instr->object());
2528 LOperand* index = UseTempRegister(instr->index()); 2527 LOperand* index = UseTempRegister(instr->index());
2529 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2528 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2530 } 2529 }
2531 2530
2532 2531
2533 } } // namespace v8::internal 2532 } } // namespace v8::internal
2534 2533
2535 #endif // V8_TARGET_ARCH_X64 2534 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698