Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 22623008: Make assert more accurate (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1691 matching lines...) Expand 10 before | Expand all | Expand 10 after
1702 LOperand* right = UseFixed(instr->right(), r0); 1702 LOperand* right = UseFixed(instr->right(), r0);
1703 LCmpT* result = new(zone()) LCmpT(left, right); 1703 LCmpT* result = new(zone()) LCmpT(left, right);
1704 return MarkAsCall(DefineFixed(result, r0), instr); 1704 return MarkAsCall(DefineFixed(result, r0), instr);
1705 } 1705 }
1706 1706
1707 1707
1708 LInstruction* LChunkBuilder::DoCompareNumericAndBranch( 1708 LInstruction* LChunkBuilder::DoCompareNumericAndBranch(
1709 HCompareNumericAndBranch* instr) { 1709 HCompareNumericAndBranch* instr) {
1710 Representation r = instr->representation(); 1710 Representation r = instr->representation();
1711 if (r.IsSmiOrInteger32()) { 1711 if (r.IsSmiOrInteger32()) {
1712 ASSERT(instr->left()->representation().IsSmiOrInteger32()); 1712 ASSERT(instr->left()->representation().Equals(r));
1713 ASSERT(instr->left()->representation().Equals( 1713 ASSERT(instr->right()->representation().Equals(r));
1714 instr->right()->representation()));
1715 LOperand* left = UseRegisterOrConstantAtStart(instr->left()); 1714 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1716 LOperand* right = UseRegisterOrConstantAtStart(instr->right()); 1715 LOperand* right = UseRegisterOrConstantAtStart(instr->right());
1717 return new(zone()) LCompareNumericAndBranch(left, right); 1716 return new(zone()) LCompareNumericAndBranch(left, right);
1718 } else { 1717 } else {
1719 ASSERT(r.IsDouble()); 1718 ASSERT(r.IsDouble());
1720 ASSERT(instr->left()->representation().IsDouble()); 1719 ASSERT(instr->left()->representation().IsDouble());
1721 ASSERT(instr->right()->representation().IsDouble()); 1720 ASSERT(instr->right()->representation().IsDouble());
1722 LOperand* left = UseRegisterAtStart(instr->left()); 1721 LOperand* left = UseRegisterAtStart(instr->left());
1723 LOperand* right = UseRegisterAtStart(instr->right()); 1722 LOperand* right = UseRegisterAtStart(instr->right());
1724 return new(zone()) LCompareNumericAndBranch(left, right); 1723 return new(zone()) LCompareNumericAndBranch(left, right);
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
2593 2592
2594 2593
2595 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2594 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2596 LOperand* object = UseRegister(instr->object()); 2595 LOperand* object = UseRegister(instr->object());
2597 LOperand* index = UseRegister(instr->index()); 2596 LOperand* index = UseRegister(instr->index());
2598 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2597 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2599 } 2598 }
2600 2599
2601 2600
2602 } } // namespace v8::internal 2601 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698