Issue 22623007: Fix smi-based math floor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22623007: Fix smi-based math floor. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -31 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		3 chunks	+21 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-smi-math-floor-round.js	View	1 2 3	1 chunk	+30 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, although slowly all those Smi/Int32 code fragments make my brain hurt. :-D

7 years, 4 months ago (2013-08-09 11:16:15 UTC) #2

Toon Verwaest

7 years, 4 months ago (2013-08-09 11:21:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r16128 (presubmit successful).