Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22623006: [Android] Install required 32-bit libs via install-build-deps-android.sh. (Closed)

Created:
7 years, 4 months ago by Siva Chandra
Modified:
7 years, 4 months ago
Reviewers:
digit, Isaac (away)
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Install required 32-bit libs via install-build-deps-android.sh. BUG=178363 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216821

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use simpler apt-get options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/install-build-deps-android.sh View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Siva Chandra
Notice that I only required to install g++ mutilib (which was obvious I guess) and ...
7 years, 4 months ago (2013-08-09 01:50:17 UTC) #1
Isaac (away)
lgtm. Please update linux_setup.sh in chrome-golo repo too.
7 years, 4 months ago (2013-08-09 01:56:16 UTC) #2
Isaac (away)
https://chromiumcodereview.appspot.com/22623006/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://chromiumcodereview.appspot.com/22623006/diff/1/build/install-build-deps-android.sh#newcode50 build/install-build-deps-android.sh:50: sudo apt-get install -qq --assume-yes lib32z1 g++-multilib why use ...
7 years, 4 months ago (2013-08-09 01:57:27 UTC) #3
Siva Chandra
Simplified the apt-get options now. https://chromiumcodereview.appspot.com/22623006/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://chromiumcodereview.appspot.com/22623006/diff/1/build/install-build-deps-android.sh#newcode50 build/install-build-deps-android.sh:50: sudo apt-get install -qq ...
7 years, 4 months ago (2013-08-09 20:35:47 UTC) #4
Siva Chandra
On 2013/08/09 01:56:16, Isaac wrote: > lgtm. Please update linux_setup.sh in chrome-golo repo too. As ...
7 years, 4 months ago (2013-08-09 20:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/22623006/7001
7 years, 4 months ago (2013-08-09 21:24:16 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 21:57:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/22623006/7001
7 years, 4 months ago (2013-08-10 02:43:19 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 07:29:16 UTC) #9
Message was sent while issue was closed. 
Change committed as 216821

Powered by Google App Engine
This is Rietveld 408576698