Issue 22623003: RenderNamedFlowThread should not create NodeRenderingContext objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22623003: RenderNamedFlowThread should not create NodeRenderingContext objects (Closed)

Created:
7 years, 4 months ago by esprehn

Modified:
7 years, 4 months ago

Reviewers:
eseidel, mihnea, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, chromiumbugtracker_adobe.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

RenderNamedFlowThread should not create NodeRenderingContext objects RenderNamedFlowThread is using NodeRenderingContext to get the original parent renderer, but should just be using NodeRenderingTraversal::parent instead (which is what NodeRenderingContext does internally anyway). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155722

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	Source/core/rendering/RenderNamedFlowThread.cpp	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/22623003/1

7 years, 4 months ago (2013-08-07 21:27:58 UTC) #3

Message was sent while issue was closed.

Change committed as 155722

Expand Messages | Collapse Messages