Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 22623002: Extract AutofillDialogController interface and common utilities. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index fb7cba09e5ea8a1c600d09dac5ef4b8663324d6d..55a0eec3470cd716f20c7e8f2f1fa71965f58f74 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -14,6 +14,7 @@
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "chrome/browser/ui/autofill/account_chooser_model.h"
+#include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
#include "chrome/browser/ui/autofill/autofill_dialog_models.h"
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h"
@@ -68,6 +69,7 @@ class WalletSigninHelper;
// This class drives the dialog that appears when a site uses the imperative
// autocomplete API to fill out a form.
class AutofillDialogControllerImpl : public AutofillDialogViewDelegate,
+ public AutofillDialogController,
public AutofillPopupDelegate,
public content::NotificationObserver,
public content::WebContentsObserver,
@@ -89,25 +91,16 @@ class AutofillDialogControllerImpl : public AutofillDialogViewDelegate,
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
- void Show();
- void Hide();
-
- // Called when the tab hosting this dialog is activated by a user gesture.
- // Used to trigger a refresh of the user's Wallet data.
- void TabActivated();
-
- // Adds a step in the flow to the Autocheckout UI.
- void AddAutocheckoutStep(AutocheckoutStepType step_type);
-
- // Updates the status of a step in the Autocheckout UI.
- void UpdateAutocheckoutStep(AutocheckoutStepType step_type,
- AutocheckoutStepStatus step_status);
-
- // Called when there is an error in an active Autocheckout flow.
- void OnAutocheckoutError();
-
- // Called when an Autocheckout flow completes successfully.
- void OnAutocheckoutSuccess();
+ // AutofillDialogController implementation.
+ virtual void Show() OVERRIDE;
+ virtual void Hide() OVERRIDE;
+ virtual void TabActivated() OVERRIDE;
+ virtual void AddAutocheckoutStep(AutocheckoutStepType step_type) OVERRIDE;
+ virtual void UpdateAutocheckoutStep(
+ AutocheckoutStepType step_type,
+ AutocheckoutStepStatus step_status) OVERRIDE;
+ virtual void OnAutocheckoutError() OVERRIDE;
+ virtual void OnAutocheckoutSuccess() OVERRIDE;
// Returns |view_| as a testable version of itself (if |view_| exists and
// actually implements |AutofillDialogView::GetTestableView()|).

Powered by Google App Engine
This is Rietveld 408576698