Issue 22622004: [Android] Removes unused and deprecated flags in test_runner.py

Issue 22622004: [Android] Removes unused and deprecated flags in test_runner.py (Closed)

Created:
7 years, 4 months ago by gkanwar1

Modified:
7 years, 4 months ago

Reviewers:
craigdh, bulach, frankf1, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Removes unused and deprecated flags in test_runner.py Flags: * --profiler * --install_apk (-I) * --disable_assertions NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216338

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removes other deprecated options #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -21 lines)			Patch
M	build/android/pylib/instrumentation/test_options.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	build/android/pylib/uiautomator/test_options.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/uiautomator/test_runner.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/test_runner.py	View	1	5 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

gkanwar1

Just spoke with Frank about this. It looks like this flag is not used anywhere, ...

7 years, 4 months ago (2013-08-07 22:43:15 UTC) #1

frankf

https://codereview.chromium.org/22622004/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/22622004/diff/1/build/android/test_runner.py#newcode169 build/android/test_runner.py:169: option_parser.add_option('--disable_assertions', action='store_true', Can you also remove this while you're ...

7 years, 4 months ago (2013-08-07 22:50:20 UTC) #2

gkanwar1

7 years, 4 months ago (2013-08-07 22:58:11 UTC) #3

frankf

On 2013/08/07 23:06:22, frankf wrote: > lgtm Please update the description.

7 years, 4 months ago (2013-08-07 23:06:42 UTC) #5

gkanwar1

On 2013/08/07 23:06:42, frankf wrote: > On 2013/08/07 23:06:22, frankf wrote: > > lgtm > ...

7 years, 4 months ago (2013-08-07 23:11:53 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/22622004/8001

7 years, 4 months ago (2013-08-08 00:53:29 UTC) #7

bulach

FYI, this is sort of used downstream... while at it, we're looking for volunteers to ...

7 years, 4 months ago (2013-08-08 09:34:51 UTC) #9

frankf1

The downstream still depends on pylib/utils/test_options_parser.py. Do you have a bug for writing the mem ...

7 years, 4 months ago (2013-08-08 16:44:20 UTC) #10

bulach

7 years, 4 months ago (2013-08-08 16:48:07 UTC) #11

Please see https://code.google.com/p/chromium/issues/detail?id=245266 and
the bugs linked in the first comment..

Thanks,
Marcus


On Thu, Aug 8, 2013 at 5:44 PM, Frank Farzan <frankf@google.com> wrote:

> The downstream still depends on pylib/utils/test_options_parser.py. Do you
> have a bug for writing the mem tests?
>
>
> On Thu, Aug 8, 2013 at 2:34 AM, <bulach@chromium.org> wrote:
>
>> FYI, this is sort of used downstream...
>>
>> while at it, we're looking for volunteers to write a few memory
>> acceptance tests
>> using telemetry, so then we can get rid of the ones downstream. any
>> interest? :)
>>
>>
>>
https://codereview.chromium.**org/22622004/<https://codereview.chromium.org/2...
>>
>
>

Expand Messages | Collapse Messages