Issue 22617003: Converts monkey test to its own test type

Issue 22617003: Converts monkey test to its own test type (Closed)

Created:
7 years, 4 months ago by gkanwar1

Modified:
7 years, 4 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Converts monkey test to its own test type NOTRY=True BUG=223650, 263479 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216343

Patch Set 2 : Inlines TEST_TOKEN #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -173 lines)			Patch
A +	build/android/pylib/monkey/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	build/android/pylib/monkey/setup.py	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	build/android/pylib/monkey/test_options.py	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	build/android/pylib/monkey/test_runner.py	View		1 chunk	+77 lines, -0 lines	0 comments	Download
D	build/android/run_monkey_test.py	View		1 chunk	+0 lines, -170 lines	0 comments	Download
M	build/android/test_runner.py	View		7 chunks	+83 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm. Thanks! https://codereview.chromium.org/22617003/diff/1/build/android/pylib/monkey/setup.py File build/android/pylib/monkey/setup.py (right): https://codereview.chromium.org/22617003/diff/1/build/android/pylib/monkey/setup.py#newcode12 build/android/pylib/monkey/setup.py:12: TEST_TOKEN = 'MonkeyTest' Just inline this.

7 years, 4 months ago (2013-08-07 22:38:23 UTC) #2

gkanwar1

Waiting on trybots. https://codereview.chromium.org/22617003/diff/1/build/android/pylib/monkey/setup.py File build/android/pylib/monkey/setup.py (right): https://codereview.chromium.org/22617003/diff/1/build/android/pylib/monkey/setup.py#newcode12 build/android/pylib/monkey/setup.py:12: TEST_TOKEN = 'MonkeyTest' On 2013/08/07 22:38:23, ...

7 years, 4 months ago (2013-08-07 22:45:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/22617003/7001

7 years, 4 months ago (2013-08-08 00:53:16 UTC) #4

Message was sent while issue was closed.

Change committed as 216343

Expand Messages | Collapse Messages