[android_webivew] Implement flingScroll, pageUp, pageDown

[android_webivew] Implement flingScroll, pageUp, pageDown

This implements the flingScroll, pageUp and pageDown AwContents methods
using the UI-thread scrolling mechanism.

BUG=None
TEST=AndroidWebViewTest
Android-only change, ran through trybots.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217000

[mkosiba (inactive), 2013-08-09 18:08:20]

PTAL

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(left):

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwContents.java:1286:
mContentViewCore.flingScroll(velocityX, velocityY);
I'll need to investigate whether these can be removed from ContentViewCore. Will
follow up on Monday.

[joth, 2013-08-09 21:13:10]

lgtm

bit rushed - I didn't read the test super close. let me know if you want to (or
find a local tz pair of eyes :)

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:26:
// pages with the space bar, in pixels.
space bar?? G1 flash back. but yeah good enough.

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:31:
private static final int MAX_SCROLL_ANIMATION_DURATION = 750;   // milliseconds
nit: _MS or MILLIS rather than comment? hmm dunno if that helps so much.

and _PX_PER_SEC ?   /shrug

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:306:
private static int computeDuration(int dx, int dy) {
input in px? comment return units? (millis?)

[mkosiba (inactive), 2013-08-12 10:56:42]

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(left):

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwContents.java:1286:
mContentViewCore.flingScroll(velocityX, velocityY);
On 2013/08/09 18:08:21, mkosiba wrote:
> I'll need to investigate whether these can be removed from ContentViewCore.
Will
> follow up on Monday.

Done.

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:26:
// pages with the space bar, in pixels.
On 2013/08/09 21:13:10, joth wrote:
> space bar?? G1 flash back. but yeah good enough.

yeath.. just copied the comment over from WebViewClassic. I can improve it
slightly.

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:31:
private static final int MAX_SCROLL_ANIMATION_DURATION = 750;   // milliseconds
On 2013/08/09 21:13:10, joth wrote:
> nit: _MS or MILLIS rather than comment? hmm dunno if that helps so much.
> 
> and _PX_PER_SEC ?   /shrug

Done.

https://codereview.chromium.org/22613004/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:306:
private static int computeDuration(int dx, int dy) {
On 2013/08/09 21:13:10, joth wrote:
> input in px? comment return units? (millis?)

agree with indicating what the return unit is. The comment at the top of the
file
says that all units are physical pixels (unless noted otherwise), so there is no
need to explicitly say that the input is in pix.

[benm (inactive), 2013-08-12 12:20:26]

lgtm

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:13:
import android.util.Log;
needed?

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:345:
dy = -mContainerViewHeight / 2;
nit: move this as initialiser for dy?

[mkosiba (inactive), 2013-08-12 13:59:42]

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
File
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
(right):

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:13:
import android.util.Log;
On 2013/08/12 12:20:26, benm wrote:
> needed?

Done.

https://codereview.chromium.org/22613004/diff/5001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:345:
dy = -mContainerViewHeight / 2;
On 2013/08/12 12:20:26, benm wrote:
> nit: move this as initialiser for dy?

Done.

[commit-bot: I haz the power, 2013-08-12 15:26:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/22613004/13001

[commit-bot: I haz the power, 2013-08-12 15:27:46]

Change committed as 217000