Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3508)

Unified Diff: blimp/client/core/BUILD.gn

Issue 2261273002: Integrate UI with authentication flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Misc fixes/ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/BUILD.gn
diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn
index 20aeb6af2246858fb5d2224228942a182db3097b..3a9696e4b7729b01f8919c52cf701cf6e35ef3a5 100644
--- a/blimp/client/core/BUILD.gn
+++ b/blimp/client/core/BUILD.gn
@@ -111,6 +111,7 @@ source_set("context") {
deps = [
":context_jni_headers",
+ "//blimp/client/core/settings",
]
}
}
@@ -154,9 +155,9 @@ if (is_android) {
deps = [
":context_java",
- ":settings_java",
":switches_java",
"//blimp/client/core/contents:contents_java",
+ "//blimp/client/core/settings:settings_java",
]
}
@@ -177,38 +178,33 @@ if (is_android) {
java_files = [ "android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java" ]
deps = [
+ ":common_java",
+ ":switches_java",
"//base:base_java",
- "//blimp/client/core:settings_java",
"//blimp/client/core/contents:contents_java",
+ "//blimp/client/core/settings:settings_java",
"//blimp/client/public:public_headers_java",
]
}
- android_library("switches_java") {
- visibility = [ "//blimp/client/*" ]
-
- java_files =
- [ "android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java" ]
- }
-
- android_library("settings_java") {
+ android_library("common_java") {
visibility = [ "//blimp/client/*" ]
- java_files = [
- "android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java",
- "android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java",
- ]
+ java_files = [ "android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java" ]
- # TODO(xingliu): Remove android support v7 dependency and move android resources to Chrome
- # after Blimp merge to Chrome.
deps = [
"//base:base_java",
- "//blimp/client:blimp_java_resources",
"//blimp/client/public:public_headers_java",
- "//third_party/android_tools:android_support_v7_appcompat_java",
]
}
+ android_library("switches_java") {
+ visibility = [ "//blimp/client/*" ]
+
+ java_files =
+ [ "android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java" ]
+ }
+
generate_jni("context_jni_headers") {
visibility = [ ":*" ]

Powered by Google App Engine
This is Rietveld 408576698