Issue 22611007: Revert "Revive Chewing IME for traditional Chinese Input."

Issue 22611007: Revert "Revive Chewing IME for traditional Chinese Input." (Closed)

Created:
7 years, 4 months ago by Seigo Nonaka

Modified:
7 years, 4 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert "Revive Chewing IME for traditional Chinese Input." This patch was intended for M29 but there is no longer any chances. BUG=266313 TBR=zork Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216583

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -4 lines)			Patch
M	chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chromeos/ime/input_methods.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Hi Zach, Unfortunately, we seems to having no chance to merge for M29. And real ...

7 years, 4 months ago (2013-08-08 03:36:38 UTC) #1

Seigo Nonaka

Submitting with TBR, this is pure-revert of https://codereview.chromium.org/20843010/

7 years, 4 months ago (2013-08-08 23:35:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/22611007/1

7 years, 4 months ago (2013-08-08 23:40:03 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-09 00:07:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/22611007/1

7 years, 4 months ago (2013-08-09 00:49:08 UTC) #5

Message was sent while issue was closed.

Change committed as 216583

Expand Messages | Collapse Messages