Issue 22611004: DCHECK that invalid app window states are not cached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22611004: DCHECK that invalid app window states are not cached. (Closed)

Created:
7 years, 4 months ago by scheib

Modified:
7 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

DCHECK that invalid app window states are not cached. Initial change to protect against loading invalid cached state should have included these DCHECKs: https://chromiumcodereview.appspot.com/21444002 BUG=266578, 269040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218624

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	apps/shell_window_geometry_cache.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	apps/shell_window_geometry_cache_unittest.cc	View	1	5 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 6 (0 generated)

asargent_no_longer_on_chrome

Looks like this DCHECK is getting hit in a unit test in your try jobs, ...

7 years, 4 months ago (2013-08-12 18:07:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/22611004/14001

7 years, 4 months ago (2013-08-21 00:14:55 UTC) #5

Message was sent while issue was closed.

Change committed as 218624