Issue 22608005: Add extra error logging to PnaclTranslationCache and PnaclHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22608005: Add extra error logging to PnaclTranslationCache and PnaclHost (Closed)

Created:
7 years, 4 months ago by Derek Schuff

Modified:
7 years, 4 months ago

Reviewers:
jvoung (off chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add extra error logging to PnaclTranslationCache and PnaclHost This will help debug any flake in the unit tests. R=jvoung@chromium.org BUG=none TEST= unit_tests --gtest_filter=Pnacl* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216798

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -12 lines)			Patch
	M	chrome/browser/nacl_host/pnacl_host.cc	View	1	7 chunks	+20 lines, -7 lines	0 comments	Download
	M	chrome/browser/nacl_host/pnacl_translation_cache.cc	View		6 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

otherwise lgtm https://codereview.chromium.org/22608005/diff/1/chrome/browser/nacl_host/pnacl_host.cc File chrome/browser/nacl_host/pnacl_host.cc (right): https://codereview.chromium.org/22608005/diff/1/chrome/browser/nacl_host/pnacl_host.cc#newcode348 chrome/browser/nacl_host/pnacl_host.cc:348: LOG(ERROR) << "PnaclHost: GetPlatformFileInfo failed"; indentation a ...

7 years, 4 months ago (2013-08-09 21:07:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/22608005/7001

7 years, 4 months ago (2013-08-09 21:12:48 UTC) #3

Message was sent while issue was closed.

Change committed as 216798

Expand Messages | Collapse Messages