[chromedriver] Restore test_expectations.

[chromedriver] Restore test_expectations.

Also fixed PYTHONPATH so that old generated *.pyc in chromedriver/ won't be picked up unexpectedly after the *.py were moved from chromedriver/ to chromedriver/test/.

TBR=kkania@chromium.org
BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216788

[frankf, 2013-08-09 21:34:11]

https://codereview.chromium.org/22601006/diff/1/chrome/test/chromedriver/test...
File chrome/test/chromedriver/test/run_java_tests.py (right):

https://codereview.chromium.org/22601006/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/run_java_tests.py:21:
sys.path.append(os.path.join(_THIS_DIR, os.pardir))
This might be problematic if there are python modules with identical names in
the PATH (chrome_paths, test_environment, util). PYTHONPATH is currently set to:

PYTHONPATH=/mnt/data/b/build/site_config:/mnt/data/b/build/scripts:/mnt/data/b/build/scripts/release:/mnt/data/b/build/third_party:/mnt/data/b/build_internal/site_config:/mnt/data/b/build_internal/symsrc:/mnt/data/b/build/slave:/mnt/data/b/build/third_party/buildbot_slave_8_4:/mnt/data/b/build/third_party/twisted_10_2:

What you need is to create python library directly and put all these imported
modules there.

[chrisgao (Use stgao instead), 2013-08-09 22:52:48]

https://codereview.chromium.org/22601006/diff/1/chrome/test/chromedriver/test...
File chrome/test/chromedriver/test/run_java_tests.py (right):

https://codereview.chromium.org/22601006/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/run_java_tests.py:21:
sys.path.append(os.path.join(_THIS_DIR, os.pardir))
On 2013/08/09 21:34:11, frankf wrote:
> This might be problematic if there are python modules with identical names in
> the PATH (chrome_paths, test_environment, util). PYTHONPATH is currently set
to:
> 
>
PYTHONPATH=/mnt/data/b/build/site_config:/mnt/data/b/build/scripts:/mnt/data/b/build/scripts/release:/mnt/data/b/build/third_party:/mnt/data/b/build_internal/site_config:/mnt/data/b/build_internal/symsrc:/mnt/data/b/build/slave:/mnt/data/b/build/third_party/buildbot_slave_8_4:/mnt/data/b/build/third_party/twisted_10_2:
> 
> What you need is to create python library directly and put all these imported
> modules there.

Good catch.

But let's make it simpler: do the insert with index=1.
Per http://docs.python.org/2/library/sys.html#sys.path, sys.path has at least
one element path[0] pointing to the script directory or the current directory.

[frankf, 2013-08-09 23:37:50]

If you want to unbreak the build, please go ahead and TBR, but address this
issue in the future.

https://codereview.chromium.org/22601006/diff/6001/chrome/test/chromedriver/t...
File chrome/test/chromedriver/test/run_java_tests.py (right):

https://codereview.chromium.org/22601006/diff/6001/chrome/test/chromedriver/t...
chrome/test/chromedriver/test/run_java_tests.py:21: sys.path.insert(1,
os.path.join(_THIS_DIR, os.pardir))
But what are these modules in the top-level instead of being in test/? They're
all used for testing right. You cam make your life much easier to have all the
python test file in the same dir.

[chrisgao (Use stgao instead), 2013-08-10 00:04:20]

https://codereview.chromium.org/22601006/diff/6001/chrome/test/chromedriver/t...
File chrome/test/chromedriver/test/run_java_tests.py (right):

https://codereview.chromium.org/22601006/diff/6001/chrome/test/chromedriver/t...
chrome/test/chromedriver/test/run_java_tests.py:21: sys.path.insert(1,
os.path.join(_THIS_DIR, os.pardir))
On 2013/08/09 23:37:50, frankf wrote:
> But what are these modules in the top-level instead of being in test/? They're
> all used for testing right. You cam make your life much easier to have all the
> python test file in the same dir.

Yes, this solution is not perfect.

It's just a workaround because *.pyc is not automatically cleaned up in the bots
and locally if a *.py is removed.

Ideally, if we had dependencies on different modules located in different
directories, we may have to isolate each of them. But I don't think it is a good
idea for the case here, as we have so few and simple modules.

I did ask Ken to move all *.py to chromedriver/test. He insisted some *.py are
to trigger the test but not the test itself.

So TBR for Ken.

[commit-bot: I haz the power, 2013-08-10 00:12:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/22601006/6001

[commit-bot: I haz the power, 2013-08-10 00:16:07]

Change committed as 216788