Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 22600005: Eliminate intentional conversion from Smi to Int32 in HMul (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Fixed navier stokes benchmark fails Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/hydrogen-representation-changes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 390
391 bool HValue::CheckUsesForFlag(Flag f) { 391 bool HValue::CheckUsesForFlag(Flag f) {
392 for (HUseIterator it(uses()); !it.Done(); it.Advance()) { 392 for (HUseIterator it(uses()); !it.Done(); it.Advance()) {
393 if (it.value()->IsSimulate()) continue; 393 if (it.value()->IsSimulate()) continue;
394 if (!it.value()->CheckFlag(f)) return false; 394 if (!it.value()->CheckFlag(f)) return false;
395 } 395 }
396 return true; 396 return true;
397 } 397 }
398 398
399 399
400 bool HValue::CheckUsesForFlag(Flag f, HValue** value) {
401 for (HUseIterator it(uses()); !it.Done(); it.Advance()) {
402 if (it.value()->IsSimulate()) continue;
403 if (!it.value()->CheckFlag(f)) {
404 *value = it.value();
405 return false;
406 }
407 }
408 return true;
409 }
410
411
400 bool HValue::HasAtLeastOneUseWithFlagAndNoneWithout(Flag f) { 412 bool HValue::HasAtLeastOneUseWithFlagAndNoneWithout(Flag f) {
401 bool return_value = false; 413 bool return_value = false;
402 for (HUseIterator it(uses()); !it.Done(); it.Advance()) { 414 for (HUseIterator it(uses()); !it.Done(); it.Advance()) {
403 if (it.value()->IsSimulate()) continue; 415 if (it.value()->IsSimulate()) continue;
404 if (!it.value()->CheckFlag(f)) return false; 416 if (!it.value()->CheckFlag(f)) return false;
405 return_value = true; 417 return_value = true;
406 } 418 }
407 return return_value; 419 return return_value;
408 } 420 }
409 421
(...skipping 3588 matching lines...) Expand 10 before | Expand all | Expand 10 after
3998 break; 4010 break;
3999 case kExternalMemory: 4011 case kExternalMemory:
4000 stream->Add("[external-memory]"); 4012 stream->Add("[external-memory]");
4001 break; 4013 break;
4002 } 4014 }
4003 4015
4004 stream->Add("@%d", offset()); 4016 stream->Add("@%d", offset());
4005 } 4017 }
4006 4018
4007 } } // namespace v8::internal 4019 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/hydrogen-representation-changes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698