Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2259553002: Make AppBannerInfoBar install WebAPK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove webpak-metrics and nits. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index b25d564d663b6d50cfd32691a46bfdb8d2285565..122a0fec71681ff5b41edf6bf876c6001c4f3926 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -12,6 +12,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
#include "chrome/browser/android/shortcut_helper.h"
+#include "chrome/browser/android/webapk/chrome_webapk_host.h"
#include "chrome/browser/banners/app_banner_metrics.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/manifest/manifest_icon_downloader.h"
@@ -177,13 +178,14 @@ void AppBannerManagerAndroid::ShowBanner() {
infobars::InfoBar* infobar = nullptr;
if (native_app_data_.is_null()) {
+ bool is_webapk = ChromeWebApkHost::AreWebApkEnabled();
std::unique_ptr<AppBannerInfoBarDelegateAndroid> delegate(
new AppBannerInfoBarDelegateAndroid(
GetWeakPtr(), app_title_, manifest_url_, manifest_, icon_url_,
- std::move(icon_), event_request_id()));
+ std::move(icon_), event_request_id(), is_webapk));
- infobar = new AppBannerInfoBarAndroid(std::move(delegate),
- manifest_.start_url);
+ infobar = new AppBannerInfoBarAndroid(
+ std::move(delegate), manifest_.start_url, is_webapk);
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);

Powered by Google App Engine
This is Rietveld 408576698