Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 22594004: Fix invalid test, fast/dom/wrapper-classes.html (Closed)

Created:
7 years, 4 months ago by arv (Not doing code reviews)
Modified:
7 years, 4 months ago
Reviewers:
haraken, do-not-use
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Fix invalid test, fast/dom/wrapper-classes.html The test incorrectly tested that the [[Class]] of the constructor was set to "FooConstructor", it should be se to "Foo". Note that we still, fail the [[Class]] tests for Foo.prototype. BUG=239175 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -478 lines) Patch
M LayoutTests/fast/dom/wrapper-classes.html View 4 chunks +22 lines, -16 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 chunk +616 lines, -462 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
arv (Not doing code reviews)
7 years, 4 months ago (2013-08-08 22:57:07 UTC) #1
haraken
LGTM
7 years, 4 months ago (2013-08-08 23:38:36 UTC) #2
do-not-use
lgtm
7 years, 4 months ago (2013-08-09 06:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/22594004/1
7 years, 4 months ago (2013-08-09 18:06:19 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 20:16:02 UTC) #5
Message was sent while issue was closed.
Change committed as 155863

Powered by Google App Engine
This is Rietveld 408576698