EVDA: Add support for dynamic resolution change and MSE players.

content/common/gpu/media/exynos_video_decode_accelerator.h

Index: content/common/gpu/media/exynos_video_decode_accelerator.h
diff --git a/content/common/gpu/media/exynos_video_decode_accelerator.h b/content/common/gpu/media/exynos_video_decode_accelerator.h
index b1b9375686846896caca83a88f3d374cb0505b9b..c41acebc2a8006315106ab3c8946c095d186cb1e 100644
--- a/content/common/gpu/media/exynos_video_decode_accelerator.h
+++ b/content/common/gpu/media/exynos_video_decode_accelerator.h
@@ -102,6 +102,8 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
     kDecoding,           // DecodeBufferInitial() successful; decoding frames.
     kResetting,          // Presently resetting.
     kAfterReset,         // After Reset(), ready to start decoding again.
+    kChangingResolution, // Performing resolution change, all remaining
+                         // pre-change frames decoded and processed.
     kError,              // Error in kDecoding state.
   };
 
@@ -205,12 +207,13 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
 
   // Service I/O on the V4L2 devices.  This task should only be scheduled from
   // DevicePollTask().
-  void ServiceDeviceTask();
+  void ServiceDeviceTask(bool event_pending);

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

Doco what |event_pending| means.
Since only MFC is inspected in DequeueEvents, I suspect both this param and that
method want to have "mfc" in the name in some way.

[Pawel Osciak, 2013/08/11 12:40:13]

Done.

   // Handle the various device queues.
   void EnqueueMfc();
   void DequeueMfc();
   void EnqueueGsc();
   void DequeueGsc();
+  void DequeueEvents();
   // Enqueue a buffer on the corresponding queue.
   bool EnqueueMfcInputRecord();
   bool EnqueueMfcOutputRecord();
@@ -245,11 +248,18 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
 
   // Attempt to start/stop device_poll_thread_.
   bool StartDevicePoll();
-  bool StopDevicePoll();
+  // |keep_mfc_input| if true, don't reset MFC input state, used during
+  // resolution change.
+  bool StopDevicePoll(bool keep_mfc_input);

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

s/input/input_state/ ?

[Pawel Osciak, 2013/08/11 12:40:13]

Done.

   // Set/clear the device poll interrupt (using device_poll_interrupt_fd_).
   bool SetDevicePollInterrupt();
   bool ClearDevicePollInterrupt();
 
+  void StartResolutionChangeIfNeeded();
+  void ResChangeDestroyBuffersOnChildThread();

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

s/Res/Resolution/

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

This "OnChildThread" is out of whack with the rest of the layout of this class
(methods divided by which thread they run on).  Can you improve this?

[Pawel Osciak, 2013/08/10 05:40:29]

I agree. I added it after John's comment on PS1, who preferred it this way. But
I'd also prefer it without it. So you guys fight it out before I get my desktop
back ;)

+  void FinishResolutionChangeTask();
+  void ResumeAfterResolutionChangeTask();
+
   //
   // Device tasks, to be run on device_poll_thread_.
   //
@@ -275,6 +285,8 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
   //
 
   // Create the buffers we need.
+  bool GetFormatInfo(struct v4l2_format* format, bool* again);

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

doco

[Pawel Osciak, 2013/08/11 12:40:13]

Done.

+  bool CreateBuffersForFormat(const struct v4l2_format& format);
   bool CreateMfcInputBuffers();
   bool CreateMfcOutputBuffers();
   bool CreateGscInputBuffers();
@@ -331,6 +343,11 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
   int decoder_frames_at_client_;
   // Are we flushing?
   bool decoder_flushing_;
+  // Got a notification from driver that it reached resolution change point
+  // in the stream.
+  bool resolution_change_pending_;
+  // Got a reset request while we were performing resolution change.
+  bool reset_pending_;

[Ami GONE FROM CHROMIUM, 2013/08/09 16:55:41]

var name should reflect fact of resolution change

[Pawel Osciak, 2013/08/11 12:40:13]

Done.

   // Input queue for decoder_thread_: BitstreamBuffers in.
   std::list<linked_ptr<BitstreamBufferRef> > decoder_input_queue_;
   // For H264 decode, hardware requires that we send it frame-sized chunks.